summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Perry Wu <wuperry@google.com> 2024-06-06 20:33:47 +0000
committer Perry Wu <wuperry@google.com> 2024-06-07 17:52:14 +0000
commita61f3959f37c101bf82a7a9fe701d552ab48037c (patch)
tree70b79243de03e61960b387b1beea1900f2bed8c5
parentfd07c424fe55deda20f471fb38355c201bc48cf1 (diff)
Only update home visibility on exit pip to fullscreen
In ag/27443168 we update home visibility when expanding pip to fix a bug with overview. However this introduced a new bug where taskbar would appear when home was not visible. This fixes the second issue by only updating home visibility when we actually expand pip. Flag: N/A Bug: 342529469 Test: Manually verify taskbar doesn't appear when dismissing pip, and that we have not regressed b/340443311 when expanding pip Change-Id: I341118278faebf446800f89572176a3e52b5bb95 (cherry picked from commit 2f3aa42739543bbe87e2d758bd696e3d696526a9)
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java
index bdfabafa6895..14550a374d3c 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java
@@ -201,9 +201,6 @@ public class PipTransition extends PipTransitionController {
animator.cancel();
}
mExitTransition = mTransitions.startTransition(type, out, this);
- if (mPipOrganizer.getOutPipWindowingMode() == WINDOWING_MODE_UNDEFINED) {
- mHomeTransitionObserver.notifyHomeVisibilityChanged(false /* isVisible */);
- }
}
@Override
@@ -645,6 +642,9 @@ public class PipTransition extends PipTransitionController {
startTransaction.remove(mPipOrganizer.mPipOverlay);
mPipOrganizer.clearContentOverlay();
}
+ if (mPipOrganizer.getOutPipWindowingMode() == WINDOWING_MODE_UNDEFINED) {
+ mHomeTransitionObserver.notifyHomeVisibilityChanged(false /* isVisible */);
+ }
if (pipChange == null) {
ProtoLog.w(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE,
"%s: No window of exiting PIP is found. Can't play expand animation", TAG);