summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jeff DeCew <jeffdq@google.com> 2021-06-03 17:04:50 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2021-06-03 17:04:50 +0000
commita39cdd127330f8941e77c287b931fe2ed9f4029c (patch)
tree3805134e4571dba83b53a368d0b278b744783768
parent80efce1f41f965565bd981d24f73a5eaa1cce8a6 (diff)
parente0fb0e6162a567c19406e780047732ab36b90be3 (diff)
Merge "Remove redundant margin update, which caused infinite layout loop." into sc-dev
-rw-r--r--core/java/com/android/internal/widget/ConversationLayout.java10
1 files changed, 0 insertions, 10 deletions
diff --git a/core/java/com/android/internal/widget/ConversationLayout.java b/core/java/com/android/internal/widget/ConversationLayout.java
index 16c205a1baf3..e6deada45fc1 100644
--- a/core/java/com/android/internal/widget/ConversationLayout.java
+++ b/core/java/com/android/internal/widget/ConversationLayout.java
@@ -150,7 +150,6 @@ public class ConversationLayout extends FrameLayout
private Icon mShortcutIcon;
private View mAppNameDivider;
private TouchDelegateComposite mTouchDelegate = new TouchDelegateComposite(this);
- private int mNotificationHeaderSeparatingMargin;
public ConversationLayout(@NonNull Context context) {
super(context);
@@ -284,8 +283,6 @@ public class ConversationLayout extends FrameLayout
mAppName.setOnVisibilityChangedListener((visibility) -> {
onAppNameVisibilityChanged();
});
- mNotificationHeaderSeparatingMargin = getResources().getDimensionPixelSize(
- R.dimen.notification_header_separating_margin);
}
@RemotableViewMethod
@@ -1031,7 +1028,6 @@ public class ConversationLayout extends FrameLayout
}
mTouchDelegate.clear();
if (mFeedbackIcon.getVisibility() == VISIBLE) {
- updateFeedbackIconMargins();
float width = Math.max(mMinTouchSize, mFeedbackIcon.getWidth());
float height = Math.max(mMinTouchSize, mFeedbackIcon.getHeight());
final Rect feedbackTouchRect = new Rect();
@@ -1057,12 +1053,6 @@ public class ConversationLayout extends FrameLayout
}
}
- private void updateFeedbackIconMargins() {
- MarginLayoutParams lp = (MarginLayoutParams) mFeedbackIcon.getLayoutParams();
- lp.setMarginStart(mNotificationHeaderSeparatingMargin);
- mFeedbackIcon.setLayoutParams(lp);
- }
-
public MessagingLinearLayout getMessagingLinearLayout() {
return mMessagingLinearLayout;
}