diff options
| author | 2014-12-03 17:44:17 +0000 | |
|---|---|---|
| committer | 2014-12-03 17:44:18 +0000 | |
| commit | a2b5067aeef5b2d68a7a2f7b4edc7ee0908b5d5b (patch) | |
| tree | db4b1a0c53a697fb010a6feba69e9b2bb11250fd | |
| parent | abdaa32dd79c915d0e419560c8eaa64e3d946b77 (diff) | |
| parent | cb7b63d928cd562ea66d10d816056b984f50193a (diff) | |
Merge "RRO: prevent duplicate system overlays"
| -rw-r--r-- | include/androidfw/AssetManager.h | 2 | ||||
| -rw-r--r-- | libs/androidfw/AssetManager.cpp | 6 |
2 files changed, 8 insertions, 0 deletions
diff --git a/include/androidfw/AssetManager.h b/include/androidfw/AssetManager.h index 99b3195bf791..0cfd2b103d23 100644 --- a/include/androidfw/AssetManager.h +++ b/include/androidfw/AssetManager.h @@ -236,9 +236,11 @@ public: private: struct asset_path { + asset_path() : path(""), type(kFileTypeRegular), idmap(""), isSystemOverlay(false) {} String8 path; FileType type; String8 idmap; + bool isSystemOverlay; }; Asset* openInPathLocked(const char* fileName, AccessMode mode, diff --git a/libs/androidfw/AssetManager.cpp b/libs/androidfw/AssetManager.cpp index 6188edbb2c8f..25cd3632bfdb 100644 --- a/libs/androidfw/AssetManager.cpp +++ b/libs/androidfw/AssetManager.cpp @@ -611,6 +611,11 @@ FileType AssetManager::getFileType(const char* fileName) } bool AssetManager::appendPathToResTable(const asset_path& ap) const { + // skip those ap's that correspond to system overlays + if (ap.isSystemOverlay) { + return true; + } + Asset* ass = NULL; ResTable* sharedRes = NULL; bool shared = true; @@ -796,6 +801,7 @@ void AssetManager::addSystemOverlays(const char* pathOverlaysList, oap.path = String8(buf, space - buf); oap.type = kFileTypeRegular; oap.idmap = String8(space + 1, newline - space - 1); + oap.isSystemOverlay = true; Asset* oass = const_cast<AssetManager*>(this)-> openNonAssetInPathLocked("resources.arsc", |