diff options
| author | 2018-12-20 17:47:37 -0800 | |
|---|---|---|
| committer | 2018-12-20 17:47:37 -0800 | |
| commit | a13a9ee3277b4221ad4790b45ea68190423b61cf (patch) | |
| tree | 978319f9cf98f696a06d3a4945ecae69c3876e20 | |
| parent | fdae9d3f01a623b243414cf7b28bf2c9a90ad601 (diff) | |
| parent | e053f576b14ea4c374eb8bc482bb6def3dec4a32 (diff) | |
Merge "Fix/suppress core/jni google-explicit-constructor warnings" am: ddeab2c144
am: e053f576b1
Change-Id: I4f616e311f55fff41b79236730d0b69d96d54cbf
| -rwxr-xr-x | core/jni/android/graphics/Bitmap.cpp | 2 | ||||
| -rw-r--r-- | core/jni/android/graphics/FontUtils.h | 2 | ||||
| -rw-r--r-- | core/jni/android/graphics/GIFMovie.cpp | 2 | ||||
| -rw-r--r-- | core/jni/fd_utils.cpp | 2 | ||||
| -rw-r--r-- | core/jni/fd_utils.h | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/core/jni/android/graphics/Bitmap.cpp b/core/jni/android/graphics/Bitmap.cpp index 5a74a2473b32..b085bc93f5dd 100755 --- a/core/jni/android/graphics/Bitmap.cpp +++ b/core/jni/android/graphics/Bitmap.cpp @@ -48,7 +48,7 @@ namespace android { class BitmapWrapper { public: - BitmapWrapper(Bitmap* bitmap) + explicit BitmapWrapper(Bitmap* bitmap) : mBitmap(bitmap) { } void freePixels() { diff --git a/core/jni/android/graphics/FontUtils.h b/core/jni/android/graphics/FontUtils.h index 9eaaa4964b66..30fdf2478887 100644 --- a/core/jni/android/graphics/FontUtils.h +++ b/core/jni/android/graphics/FontUtils.h @@ -27,7 +27,7 @@ class FontFamily; namespace android { struct FontFamilyWrapper { - FontFamilyWrapper(std::shared_ptr<minikin::FontFamily>&& family) : family(family) {} + explicit FontFamilyWrapper(std::shared_ptr<minikin::FontFamily>&& family) : family(family) {} std::shared_ptr<minikin::FontFamily> family; }; diff --git a/core/jni/android/graphics/GIFMovie.cpp b/core/jni/android/graphics/GIFMovie.cpp index dd99b377988f..f84a4bd09073 100644 --- a/core/jni/android/graphics/GIFMovie.cpp +++ b/core/jni/android/graphics/GIFMovie.cpp @@ -21,7 +21,7 @@ class GIFMovie : public Movie { public: - GIFMovie(SkStream* stream); + explicit GIFMovie(SkStream* stream); virtual ~GIFMovie(); protected: diff --git a/core/jni/fd_utils.cpp b/core/jni/fd_utils.cpp index a03e929fa60b..d8d919df6c24 100644 --- a/core/jni/fd_utils.cpp +++ b/core/jni/fd_utils.cpp @@ -148,7 +148,7 @@ class FileDescriptorInfo { const bool is_sock; private: - FileDescriptorInfo(int fd); + explicit FileDescriptorInfo(int fd); FileDescriptorInfo(struct stat stat, const std::string& file_path, int fd, int open_flags, int fd_flags, int fs_flags, off_t offset); diff --git a/core/jni/fd_utils.h b/core/jni/fd_utils.h index a3570d7ed1fb..09022a2e2408 100644 --- a/core/jni/fd_utils.h +++ b/core/jni/fd_utils.h @@ -86,7 +86,7 @@ class FileDescriptorTable { bool ReopenOrDetach(std::string* error_msg); private: - FileDescriptorTable(const std::unordered_map<int, FileDescriptorInfo*>& map); + explicit FileDescriptorTable(const std::unordered_map<int, FileDescriptorInfo*>& map); bool RestatInternal(std::set<int>& open_fds, std::string* error_msg); |