summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Frank Li <lifr@google.com> 2022-01-21 09:19:34 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2022-01-21 09:19:34 +0000
commita078c73c4745ed59d0e6f0f367d1bae943f56ac3 (patch)
tree244bdebfcb1757f8d8830d498dad438b00b0029a
parente44282f8978ffeadf000079714fa9c53942b963c (diff)
parent77fb00ddde6c6130057c87f5f2244189852c0242 (diff)
Merge "[DU07]Remove BatteryStatsImpl NetworkStats.subtract dependences"
-rw-r--r--core/java/com/android/internal/os/BatteryStatsImpl.java19
1 files changed, 2 insertions, 17 deletions
diff --git a/core/java/com/android/internal/os/BatteryStatsImpl.java b/core/java/com/android/internal/os/BatteryStatsImpl.java
index 8e9877e3cc1f..8faffacecd9e 100644
--- a/core/java/com/android/internal/os/BatteryStatsImpl.java
+++ b/core/java/com/android/internal/os/BatteryStatsImpl.java
@@ -83,7 +83,6 @@ import android.util.Log;
import android.util.LongSparseArray;
import android.util.LongSparseLongArray;
import android.util.MutableInt;
-import android.util.Pools;
import android.util.PrintWriterPrinter;
import android.util.Printer;
import android.util.Slog;
@@ -11520,8 +11519,6 @@ public class BatteryStatsImpl extends BatteryStats {
}
}
- private final Pools.Pool<NetworkStats> mNetworkStatsPool = new Pools.SynchronizedPool<>(6);
-
private final Object mWifiNetworkLock = new Object();
@GuardedBy("mWifiNetworkLock")
@@ -11566,18 +11563,13 @@ public class BatteryStatsImpl extends BatteryStats {
synchronized (mWifiNetworkLock) {
final NetworkStats latestStats = readWifiNetworkStatsLocked(networkStatsManager);
if (latestStats != null) {
- delta = NetworkStats.subtract(latestStats, mLastWifiNetworkStats, null, null,
- mNetworkStatsPool.acquire());
- mNetworkStatsPool.release(mLastWifiNetworkStats);
+ delta = latestStats.subtract(mLastWifiNetworkStats);
mLastWifiNetworkStats = latestStats;
}
}
synchronized (this) {
if (!mOnBatteryInternal || mIgnoreNextExternalStats) {
- if (delta != null) {
- mNetworkStatsPool.release(delta);
- }
if (mIgnoreNextExternalStats) {
// TODO: Strictly speaking, we should re-mark all 5 timers for each uid (and the
// global one) here like we do for display. But I'm not sure it's worth the
@@ -11684,7 +11676,6 @@ public class BatteryStatsImpl extends BatteryStats {
uidRunningMs, uidScanMs, uidBatchScanMs));
}
}
- mNetworkStatsPool.release(delta);
delta = null;
}
@@ -11933,18 +11924,13 @@ public class BatteryStatsImpl extends BatteryStats {
synchronized (mModemNetworkLock) {
final NetworkStats latestStats = readMobileNetworkStatsLocked(networkStatsManager);
if (latestStats != null) {
- delta = NetworkStats.subtract(latestStats, mLastModemNetworkStats, null, null,
- mNetworkStatsPool.acquire());
- mNetworkStatsPool.release(mLastModemNetworkStats);
+ delta = latestStats.subtract(mLastModemNetworkStats);
mLastModemNetworkStats = latestStats;
}
}
synchronized (this) {
if (!mOnBatteryInternal || mIgnoreNextExternalStats) {
- if (delta != null) {
- mNetworkStatsPool.release(delta);
- }
return;
}
@@ -12146,7 +12132,6 @@ public class BatteryStatsImpl extends BatteryStats {
totalEstimatedConsumptionMah);
}
- mNetworkStatsPool.release(delta);
delta = null;
}
}