summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yohei Yukawa <yukawa@google.com> 2024-04-13 05:53:14 +0000
committer Yohei Yukawa <yukawa@google.com> 2024-04-13 05:53:14 +0000
commita077feeb53e82ab1f7f020710f5e37da558578ba (patch)
tree28fcdaaba9668168277e68ddabb481dfe3c53cf5
parent3473ec33074d26c1a9920efc1ef2c241304dbbd1 (diff)
Remove redundant call of queryInputMethodServicesInternal (2nd try)
This is the 2nd attempt of submitting my previous CL [1], which got reverted [2] due to a boottime regression (Bug 329414077). We have already addressed the major contributor of the boot time regression [3], so this CL should be ready to be submitted again. To follow up my previous CL [4], which introduced InputMethodSettingsRepository as a read-only mode again. There was a redundant invocation of InputMethodManagerService#queryInputMethodServicesInternal, in MyPackageMonitor#onFinishPackageChangesInternal(). This CL fixes it. [1]: I9437455cd9ad907a3587b8087c2aa2620ef4c8fd e5475c78d31a4dcb5b4e1ce2e12eaf30d0315555 [2]: Ib1ae7a2ac556799a7243ba2798bae3910a74d297 fa26cc98aa2eb8da2f3c615660e01946d65cbc4d [3]: I8e51b1ced4dc16cdca7e898885c64793665fafef bce89b5742781e680efac88cbc7179bf029638d9 [4]: Ic0dd655fbd86b8ccce2b3298b4c70359a468f9ec 8130073e978ab0a826ecfab9bee1254551023a32 Bug: 309837937 Bug: 333591545 Test: presubmit Change-Id: I6c92bd92088aad022655d03acd6e535ed872d63b
-rw-r--r--services/core/java/com/android/server/inputmethod/InputMethodManagerService.java3
1 files changed, 1 insertions, 2 deletions
diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
index 6b33199ec230..333c9b58214f 100644
--- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
@@ -1135,8 +1135,7 @@ public final class InputMethodManagerService implements IInputMethodManagerImpl.
if (!isCurrentUser) {
return;
}
- mSettings = queryInputMethodServicesInternal(mContext, userId,
- newAdditionalSubtypeMap, DirectBootAwareness.AUTO);
+ mSettings = newSettings;
postInputMethodSettingUpdatedLocked(false /* resetDefaultEnabledIme */);
boolean changed = false;