diff options
| author | 2022-09-12 06:36:45 +0000 | |
|---|---|---|
| committer | 2022-09-12 06:36:45 +0000 | |
| commit | 9fefe95ba6f566c5993ed84d40e10be533c4cb2e (patch) | |
| tree | 0782922b7ecdb030df5675cb7788cdf11e8bb82c | |
| parent | de5f0ae846e6ad68cec36fa7b502a51685d834c3 (diff) | |
| parent | d66df0deb4462b1345291b8513383d0d4b638034 (diff) | |
Merge "Remove unnecessary calculation of display configuration" into tm-qpr-dev
3 files changed, 2 insertions, 22 deletions
diff --git a/services/core/java/com/android/server/wm/DisplayContent.java b/services/core/java/com/android/server/wm/DisplayContent.java index 720b08285f17..ca02e7d9cca5 100644 --- a/services/core/java/com/android/server/wm/DisplayContent.java +++ b/services/core/java/com/android/server/wm/DisplayContent.java @@ -1614,24 +1614,6 @@ class DisplayContent extends RootDisplayArea implements WindowManagerPolicy.Disp } config = new Configuration(); computeScreenConfiguration(config); - } else if (!(mTransitionController.isCollecting(this) - // If waiting for a remote display change, don't prematurely update configuration. - || mRemoteDisplayChangeController.isWaitingForRemoteDisplayChange())) { - // No obvious action we need to take, but if our current state mismatches the - // activity manager's, update it, disregarding font scale, which should remain set - // to the value of the previous configuration. - // Here we're calling Configuration#unset() instead of setToDefaults() because we - // need to keep override configs clear of non-empty values (e.g. fontSize). - final Configuration currentConfig = getRequestedOverrideConfiguration(); - mTmpConfiguration.unset(); - mTmpConfiguration.updateFrom(currentConfig); - computeScreenConfiguration(mTmpConfiguration); - if (currentConfig.diff(mTmpConfiguration) != 0) { - mWaitingForConfig = true; - setLayoutNeeded(); - mDisplayRotation.prepareNormalRotationAnimation(); - config = new Configuration(mTmpConfiguration); - } } return config; diff --git a/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java b/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java index bbd7695fc8cd..95e9f20011d0 100644 --- a/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java +++ b/services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java @@ -2993,6 +2993,7 @@ public class ActivityRecordTests extends WindowTestsBase { // Add a decor insets provider window. final WindowState navbar = createNavBarWithProvidedInsets(squareDisplay); squareDisplay.getDisplayPolicy().updateDecorInsetsInfoIfNeeded(navbar); + squareDisplay.sendNewConfiguration(); final Task task = new TaskBuilder(mSupervisor).setDisplay(squareDisplay).build(); // create a fixed portrait activity diff --git a/services/tests/wmtests/src/com/android/server/wm/ActivityTaskManagerServiceTests.java b/services/tests/wmtests/src/com/android/server/wm/ActivityTaskManagerServiceTests.java index 20b1120d7d3e..2fccd64bceca 100644 --- a/services/tests/wmtests/src/com/android/server/wm/ActivityTaskManagerServiceTests.java +++ b/services/tests/wmtests/src/com/android/server/wm/ActivityTaskManagerServiceTests.java @@ -220,10 +220,7 @@ public class ActivityTaskManagerServiceTests extends WindowTestsBase { // Check that changes are reported Configuration c = new Configuration(newDisp1.getRequestedOverrideConfiguration()); c.windowConfiguration.setBounds(new Rect(0, 0, 1000, 1300)); - newDisp1.onRequestedOverrideConfigurationChanged(c); - mAtm.mRootWindowContainer.ensureVisibilityAndConfig(null /* starting */, - newDisp1.mDisplayId, false /* markFrozenIfConfigChanged */, - false /* deferResume */); + newDisp1.performDisplayOverrideConfigUpdate(c); assertEquals(0, added.size()); assertEquals(1, changed.size()); assertEquals(0, removed.size()); |