diff options
| author | 2014-05-22 16:47:35 -0700 | |
|---|---|---|
| committer | 2014-05-22 16:47:35 -0700 | |
| commit | 9e6d1880c288d7d0ddcb651dda88d069f058eced (patch) | |
| tree | df868c077d987f5f3980164d39ff258a69fecd88 | |
| parent | fa7c755a920dc0209efa15a65bfdd2881cb42141 (diff) | |
Camera2: Raw is not croppable
Update spec doc to clarify that raw stream is not croppable.
Bug: 15168075
Change-Id: I4ffa8e2a06acd17913426ba37744bb9df1bc7330
| -rw-r--r-- | core/java/android/hardware/camera2/CaptureRequest.java | 7 | ||||
| -rw-r--r-- | core/java/android/hardware/camera2/CaptureResult.java | 7 |
2 files changed, 10 insertions, 4 deletions
diff --git a/core/java/android/hardware/camera2/CaptureRequest.java b/core/java/android/hardware/camera2/CaptureRequest.java index 00b077284ce4..b44b8088d524 100644 --- a/core/java/android/hardware/camera2/CaptureRequest.java +++ b/core/java/android/hardware/camera2/CaptureRequest.java @@ -1126,8 +1126,11 @@ public final class CaptureRequest extends CameraMetadata implements Parcelable { * output, cropping to a smaller region if necessary to * maintain the stream's aspect ratio.</p> * <p>HAL2.x uses only (x, y, width)</p> - * <p>Any additional per-stream cropping must be done to - * maximize the final pixel area of the stream.</p> + * <p>The crop region is applied after the RAW to other color space (e.g. YUV) + * conversion. Since raw streams (e.g. RAW16) don't have the conversion stage, + * it is not croppable. The crop region will be ignored by raw streams.</p> + * <p>For non-raw streams, any additional per-stream cropping will + * be done to maximize the final pixel area of the stream.</p> * <p>For example, if the crop region is set to a 4:3 aspect * ratio, then 4:3 streams should use the exact crop * region. 16:9 streams should further crop vertically diff --git a/core/java/android/hardware/camera2/CaptureResult.java b/core/java/android/hardware/camera2/CaptureResult.java index f0cbbe694d04..b0cacf12c64f 100644 --- a/core/java/android/hardware/camera2/CaptureResult.java +++ b/core/java/android/hardware/camera2/CaptureResult.java @@ -1749,8 +1749,11 @@ public final class CaptureResult extends CameraMetadata { * output, cropping to a smaller region if necessary to * maintain the stream's aspect ratio.</p> * <p>HAL2.x uses only (x, y, width)</p> - * <p>Any additional per-stream cropping must be done to - * maximize the final pixel area of the stream.</p> + * <p>The crop region is applied after the RAW to other color space (e.g. YUV) + * conversion. Since raw streams (e.g. RAW16) don't have the conversion stage, + * it is not croppable. The crop region will be ignored by raw streams.</p> + * <p>For non-raw streams, any additional per-stream cropping will + * be done to maximize the final pixel area of the stream.</p> * <p>For example, if the crop region is set to a 4:3 aspect * ratio, then 4:3 streams should use the exact crop * region. 16:9 streams should further crop vertically |