diff options
| author | 2022-11-22 04:19:16 +0000 | |
|---|---|---|
| committer | 2022-11-22 04:19:16 +0000 | |
| commit | 9d18bcbc52c64dbbd90de765423736d5fcbdb879 (patch) | |
| tree | 0208703142ed1d55dbbee91ef693ea685a08efbe | |
| parent | 480d734cee3fea10ada863845ef9e4663add3ad1 (diff) | |
| parent | afd9d50f8b2ba78e153769802e89565de449887a (diff) | |
Merge "QR Code Scanner tile says "Updating" when GMSCORE is updating" into tm-qpr-dev am: afd9d50f8b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/20489494
Change-Id: I1487a04a07c9ddaeb6a6ef3338db140615b7e30c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
3 files changed, 11 insertions, 0 deletions
diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index 5086cd706f48..3e7b0f146b39 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -1321,6 +1321,9 @@ <!-- QR Code Scanner label, title [CHAR LIMIT=32] --> <string name="qr_code_scanner_title">QR code scanner</string> + <!-- QR Code Scanner Secondary label when GMS Core is Updating --> + <string name="qr_code_scanner_updating_secondary_label">Updating</string> + <!-- Name of the work status bar icon. --> <string name="status_bar_work">Work profile</string> diff --git a/packages/SystemUI/src/com/android/systemui/qs/tiles/QRCodeScannerTile.java b/packages/SystemUI/src/com/android/systemui/qs/tiles/QRCodeScannerTile.java index 1a24af10ab08..6d50b562cd02 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/tiles/QRCodeScannerTile.java +++ b/packages/SystemUI/src/com/android/systemui/qs/tiles/QRCodeScannerTile.java @@ -117,6 +117,10 @@ public class QRCodeScannerTile extends QSTileImpl<QSTile.State> { state.icon = ResourceIcon.get(R.drawable.ic_qr_code_scanner); state.state = mQRCodeScannerController.isAbleToOpenCameraApp() ? Tile.STATE_INACTIVE : Tile.STATE_UNAVAILABLE; + // The assumption is that if the OEM has the QR code scanner module enabled then the scanner + // would go to "Unavailable" state only when GMS core is updating. + state.secondaryLabel = state.state == Tile.STATE_UNAVAILABLE + ? mContext.getString(R.string.qr_code_scanner_updating_secondary_label) : null; } @Override diff --git a/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/QRCodeScannerTileTest.java b/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/QRCodeScannerTileTest.java index 6a3f785e1d52..a1be2f3ac8de 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/QRCodeScannerTileTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/QRCodeScannerTileTest.java @@ -18,6 +18,7 @@ package com.android.systemui.qs.tiles; import static junit.framework.Assert.assertEquals; import static junit.framework.Assert.assertFalse; +import static junit.framework.Assert.assertNull; import static org.mockito.Mockito.when; @@ -112,6 +113,8 @@ public class QRCodeScannerTileTest extends SysuiTestCase { QSTile.State state = new QSTile.State(); mTile.handleUpdateState(state, null); assertEquals(state.state, Tile.STATE_UNAVAILABLE); + assertEquals(state.secondaryLabel.toString(), + mContext.getString(R.string.qr_code_scanner_updating_secondary_label)); } @Test @@ -120,5 +123,6 @@ public class QRCodeScannerTileTest extends SysuiTestCase { QSTile.State state = new QSTile.State(); mTile.handleUpdateState(state, null); assertEquals(state.state, Tile.STATE_INACTIVE); + assertNull(state.secondaryLabel); } } |