summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Narayan Kamath <narayan@google.com> 2015-06-25 09:48:46 +0000
committer Android Git Automerger <android-git-automerger@android.com> 2015-06-25 09:48:46 +0000
commit9d01914a89bc693e21809fabf46281e638b93f85 (patch)
tree67ca493e218ddadc0d7a0072c245f0fcbad3c62d
parent37c688948d4464d636cd64c537b98697cb4b795d (diff)
parentfdb70dc4346f801673aa700f3fca2b8cc77b809c (diff)
am fdb70dc4: Merge "Fix filedescriptor leakage in MediaMetadataRetriever"
* commit 'fdb70dc4346f801673aa700f3fca2b8cc77b809c': Fix filedescriptor leakage in MediaMetadataRetriever
-rw-r--r--media/java/android/media/MediaMetadataRetriever.java10
1 files changed, 1 insertions, 9 deletions
diff --git a/media/java/android/media/MediaMetadataRetriever.java b/media/java/android/media/MediaMetadataRetriever.java
index 9a69c067e498..9a73dfcd275b 100644
--- a/media/java/android/media/MediaMetadataRetriever.java
+++ b/media/java/android/media/MediaMetadataRetriever.java
@@ -64,9 +64,7 @@ public class MediaMetadataRetriever
throw new IllegalArgumentException();
}
- FileInputStream is = null;
- try {
- is = new FileInputStream(path);
+ try (FileInputStream is = new FileInputStream(path)) {
FileDescriptor fd = is.getFD();
setDataSource(fd, 0, 0x7ffffffffffffffL);
} catch (FileNotFoundException fileEx) {
@@ -74,12 +72,6 @@ public class MediaMetadataRetriever
} catch (IOException ioEx) {
throw new IllegalArgumentException();
}
-
- try {
- if (is != null) {
- is.close();
- }
- } catch (Exception e) {}
}
/**