diff options
| author | 2024-08-08 16:13:59 -0400 | |
|---|---|---|
| committer | 2024-08-08 16:15:56 -0400 | |
| commit | 9c3ba59c5475d2c2bf103c22e4d1db7dd0ec4dc4 (patch) | |
| tree | 66abad9365633fc34708cc05c497982f1c6fd72f | |
| parent | 2c39967646f508aa535c50d2c13d3c5e0765d6f4 (diff) | |
Flag off parts of SBKVM/KVM#reset.
These calls can cause spurious shade expansion events that cause tests to fail in setup. We are trying to get rid of "reset" as a concept in the refactor, and have views/state that need to be "reset" respond to the actual state changes instead.
Bug: 278086361
Flag: com.android.systemui.keyguard_wm_state_refactor
Test: cts presubmits
Change-Id: I7152f6e49c3396f62f2720195be06d00c0e5ca20
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java | 6 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java | 6 |
2 files changed, 11 insertions, 1 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java b/packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java index 0b3d0f7160f0..595b3cd3ad2e 100644 --- a/packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java +++ b/packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java @@ -2334,6 +2334,12 @@ public class KeyguardViewMediator implements CoreStartable, Dumpable, Log.e(TAG, "doKeyguard: we're still showing, but going away. Re-show the " + "keyguard rather than short-circuiting and resetting."); } else { + // We're removing "reset" in the refactor - "resetting" the views will happen + // as a reaction to the root cause of the "reset" signal. + if (KeyguardWmStateRefactor.isEnabled()) { + return; + } + // It's already showing, and we're not trying to show it while the screen is // off. We can simply reset all of the views, but don't hide the bouncer in case // the user is currently interacting with it. diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java index 2d775b74eb32..57e7dc74a24d 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java @@ -965,7 +965,11 @@ public class StatusBarKeyguardViewManager implements RemoteInputController.Callb if (isOccluded && !mDozing) { mCentralSurfaces.hideKeyguard(); if (hideBouncerWhenShowing || needsFullscreenBouncer()) { - hideBouncer(false /* destroyView */); + // We're removing "reset" in the refactor - bouncer will be hidden by the root + // cause of the "reset" calls. + if (!KeyguardWmStateRefactor.isEnabled()) { + hideBouncer(false /* destroyView */); + } } } else { showBouncerOrKeyguard(hideBouncerWhenShowing); |