summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Greg Kaiser <gkaiser@google.com> 2021-01-19 07:35:49 -0800
committer Greg Kaiser <gkaiser@google.com> 2021-01-19 07:35:49 -0800
commit9c1f79f75d76fd4700deba21a28ce54fe3489b0c (patch)
tree457c5af0fe575d096f222597a6a1ef2e1a9f2c2f
parent2d1cdb339b12bb7f74e6d3333ec9f10c1f6a9e03 (diff)
RuntimeShader: Invoke va_end()
We locally cache our return value so we can call va_end() prior to returning. Test: TreeHugger Change-Id: Ieb453512a39e8f229db006a31ce8e7e7ec69e882
-rw-r--r--libs/hwui/jni/Shader.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/libs/hwui/jni/Shader.cpp b/libs/hwui/jni/Shader.cpp
index ad3fd552204e..1dc5cd99eed1 100644
--- a/libs/hwui/jni/Shader.cpp
+++ b/libs/hwui/jni/Shader.cpp
@@ -269,8 +269,9 @@ static jlong RuntimeShader_create(JNIEnv* env, jobject, jlong shaderBuilder, jlo
static inline int ThrowIAEFmt(JNIEnv* env, const char* fmt, ...) {
va_list args;
va_start(args, fmt);
- return jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", fmt, args);
+ int ret = jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", fmt, args);
va_end(args);
+ return ret;
}
static void RuntimeShader_updateUniforms(JNIEnv* env, jobject, jlong shaderBuilder,