summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2020-01-29 15:01:41 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2020-01-29 15:01:41 +0000
commit9aa3142e8a1a6bf50118f2880b4d6db6b29930fa (patch)
tree52a86237f93cc547cdbb1f8e491e3e5bf059c7d2
parente7e55645e1f18aa2ec2121e83364876a12b1c1a7 (diff)
parentcbddf0d760afdef6d1b11f89ae697904a4803c70 (diff)
Merge "Removing the potential null object access."
-rw-r--r--services/core/java/com/android/server/pm/DataLoaderManagerService.java11
1 files changed, 1 insertions, 10 deletions
diff --git a/services/core/java/com/android/server/pm/DataLoaderManagerService.java b/services/core/java/com/android/server/pm/DataLoaderManagerService.java
index 0dfea7fd5f96..50cd0fcbbb17 100644
--- a/services/core/java/com/android/server/pm/DataLoaderManagerService.java
+++ b/services/core/java/com/android/server/pm/DataLoaderManagerService.java
@@ -50,7 +50,7 @@ public class DataLoaderManagerService extends SystemService {
private final DataLoaderManagerBinderService mBinderService;
private final Object mLock = new Object();
@GuardedBy("mLock")
- private SparseArray<DataLoaderServiceConnection> mServiceConnections;
+ private SparseArray<DataLoaderServiceConnection> mServiceConnections = new SparseArray<>();
public DataLoaderManagerService(Context context) {
super(context);
@@ -68,9 +68,6 @@ public class DataLoaderManagerService extends SystemService {
public boolean initializeDataLoader(int dataLoaderId, Bundle params,
IDataLoaderStatusListener listener) {
synchronized (mLock) {
- if (mServiceConnections == null) {
- mServiceConnections = new SparseArray<>();
- }
if (mServiceConnections.get(dataLoaderId) != null) {
Slog.e(TAG, "Data loader of ID=" + dataLoaderId + " already exists.");
return false;
@@ -156,9 +153,6 @@ public class DataLoaderManagerService extends SystemService {
@Override
public @Nullable IDataLoader getDataLoader(int dataLoaderId) {
synchronized (mLock) {
- if (mServiceConnections == null) {
- return null;
- }
DataLoaderServiceConnection serviceConnection = mServiceConnections.get(
dataLoaderId, null);
if (serviceConnection == null) {
@@ -174,9 +168,6 @@ public class DataLoaderManagerService extends SystemService {
@Override
public void destroyDataLoader(int dataLoaderId) {
synchronized (mLock) {
- if (mServiceConnections == null) {
- return;
- }
DataLoaderServiceConnection serviceConnection = mServiceConnections.get(
dataLoaderId, null);