diff options
| author | 2019-01-30 13:42:26 -0800 | |
|---|---|---|
| committer | 2019-01-31 13:00:36 -0800 | |
| commit | 98d06bd9a4b4687fd4412536417070f3c1cfae49 (patch) | |
| tree | 6aae090e1939dc1437944fc79f13046974fbf995 | |
| parent | b39aaa494bd6f0dae88fc7fa7f52bee7b89bda9b (diff) | |
Removed SSID from connected Passpoint network summary
Special case for connected Passpoint network summary has been removed.
Text should now display "Connected" instead of "<SSID> by <ProviderName>
Bug: 118705403
Test: manual, build and visual check
Change-Id: I458ea3df35fc942b9f920213ef5310d00ffe1747
| -rw-r--r-- | packages/SettingsLib/res/values/strings.xml | 2 | ||||
| -rw-r--r-- | packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java | 29 |
2 files changed, 6 insertions, 25 deletions
diff --git a/packages/SettingsLib/res/values/strings.xml b/packages/SettingsLib/res/values/strings.xml index 191bd8fadaf8..3e904a34959e 100644 --- a/packages/SettingsLib/res/values/strings.xml +++ b/packages/SettingsLib/res/values/strings.xml @@ -101,8 +101,6 @@ <string name="connected_via_passpoint">Connected via %1$s</string> <!-- Status message of Wi-Fi when it is connected by a app (via suggestion or network request). [CHAR LIMIT=NONE] --> <string name="connected_via_app">Connected via <xliff:g id="name" example="Wifi App">%1$s</xliff:g></string> - <!-- Status message of Wi-Fi when it is connected by Passpoint configuration. [CHAR LIMIT=NONE] --> - <string name="ssid_by_passpoint_provider"><xliff:g id="ssid" example="Cafe Wifi">%1$s</xliff:g> by <xliff:g id="passpointProvider" example="Passpoint Provider">%2$s</xliff:g></string> <!-- Status message of Wi-Fi when network has matching passpoint credentials. [CHAR LIMIT=NONE] --> <string name="available_via_passpoint">Available via %1$s</string> <!-- Status message of OSU Provider network when not connected. [CHAR LIMIT=NONE] --> diff --git a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java index ed8b48742f98..ac2c2c946725 100644 --- a/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java +++ b/packages/SettingsLib/src/com/android/settingslib/wifi/AccessPoint.java @@ -899,8 +899,9 @@ public class AccessPoint implements Comparable<AccessPoint> { } else if (isActive()) { if (isPasspoint()) { // This is the active connection on passpoint - summary.append(getSummary(mContext, ssid, getDetailedState(), - false, null, mConfig.providerFriendlyName)); + summary.append(getSummary(mContext, /* ssid */ null, getDetailedState(), + /* isEphemeral */ false, + /* suggestionOrSpecifierPackageName */ null)); } else if (mConfig != null && getDetailedState() == DetailedState.CONNECTED && mIsCarrierAp) { // This is the active connection on a carrier AP @@ -908,7 +909,7 @@ public class AccessPoint implements Comparable<AccessPoint> { mCarrierName)); } else { // This is the active connection on non-passpoint network - summary.append(getSummary(mContext, getDetailedState(), + summary.append(getSummary(mContext, /* ssid */ null, getDetailedState(), mInfo != null && mInfo.isEphemeral(), mInfo != null ? mInfo.getNetworkSuggestionOrSpecifierPackageName() : null)); } @@ -1340,14 +1341,9 @@ public class AccessPoint implements Comparable<AccessPoint> { } public static String getSummary(Context context, String ssid, DetailedState state, - boolean isEphemeral, String suggestionOrSpecifierPackageName, - String passpointProvider) { + boolean isEphemeral, String suggestionOrSpecifierPackageName) { if (state == DetailedState.CONNECTED) { - if (!TextUtils.isEmpty(passpointProvider)) { - // Special case for connected + passpoint networks. - String format = context.getString(R.string.ssid_by_passpoint_provider); - return String.format(format, ssid, passpointProvider); - } else if (isEphemeral && !TextUtils.isEmpty(suggestionOrSpecifierPackageName)) { + if (isEphemeral && !TextUtils.isEmpty(suggestionOrSpecifierPackageName)) { CharSequence appLabel = getAppLabel(suggestionOrSpecifierPackageName, context.getPackageManager()); return context.getString(R.string.connected_via_app, appLabel); @@ -1401,19 +1397,6 @@ public class AccessPoint implements Comparable<AccessPoint> { return String.format(formats[index], ssid); } - public static String getSummary(Context context, DetailedState state, boolean isEphemeral, - String suggestionOrSpecifierPackageName) { - return getSummary(context, null, state, isEphemeral, suggestionOrSpecifierPackageName, - null); - } - - public static String getSummary(Context context, DetailedState state, boolean isEphemeral, - String suggestionOrSpecifierPackageName, - String passpointProvider) { - return getSummary(context, null, state, false, suggestionOrSpecifierPackageName, - passpointProvider); - } - public static String convertToQuotedString(String string) { return "\"" + string + "\""; } |