summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Etan Cohen <etancohen@google.com> 2019-05-23 09:16:26 -0700
committer Etan Cohen <etancohen@google.com> 2019-05-23 16:23:13 +0000
commit9869b47cc2a62c92b13f1aaba77fe6d063291fc1 (patch)
tree9c8e195b02cc258806936919af050079bc9801dd
parent46c23572b616e07d6b1958498f2989358dd9a8bb (diff)
[CM] Fix NPE due to unvalidated callback value
Fix flaky test resulting from the above fix. Bug: 132950880 Test: atest ConnectivityServiceTest Merged-In: Ia2cc04b42288ea987483e5ab0e0a10093dc49502 Change-Id: Ia2cc04b42288ea987483e5ab0e0a10093dc49502 (cherry picked from commit cc65a628eb1172dc7b942d7f51b702099c15c23b)
-rw-r--r--tests/net/java/com/android/server/ConnectivityServiceTest.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/net/java/com/android/server/ConnectivityServiceTest.java b/tests/net/java/com/android/server/ConnectivityServiceTest.java
index 03af9672c1b3..fa059fa9e814 100644
--- a/tests/net/java/com/android/server/ConnectivityServiceTest.java
+++ b/tests/net/java/com/android/server/ConnectivityServiceTest.java
@@ -3864,6 +3864,7 @@ public class ConnectivityServiceTest {
}
}
+ testFactory.expectRemoveRequests(1);
if (preUnregister) {
mCm.unregisterNetworkCallback(networkCallback);
@@ -3873,7 +3874,6 @@ public class ConnectivityServiceTest {
testFactory.triggerUnfulfillable(requests.get(newRequestId));
} else {
// Simulate the factory releasing the request as unfulfillable and expect onUnavailable!
- testFactory.expectRemoveRequests(1);
testFactory.triggerUnfulfillable(requests.get(newRequestId));
networkCallback.expectCallback(CallbackState.UNAVAILABLE, null);