summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Coco Duan <cocod@google.com> 2023-11-16 00:48:56 +0000
committer Coco Duan <cocod@google.com> 2023-11-16 15:20:30 +0000
commit98610cea0ba174de50c68a8f9c93bbefd8ab57d5 (patch)
treec2a30745cb31ade08d214d094743b8d7916e5442
parent831a9637eefae6977845fd3a75a90338b7ed4ec7 (diff)
Fix random widget getting displayed after adding a widget
Once the lazygrid gets big enough to overscroll, adding a widget ends up rendering a random view of another widget in the grid. A tentative fix is to remove the `onReset` to always recompose the view, though this makes the performance worse. Bug: b/311319994 Test: manual Flag: ACONFIG com.android.systemui.communal_hub DEVELOPMENT Change-Id: Ie39276e6ee4ab0d9dc8a3077c3201a529e0df4f9
-rw-r--r--packages/SystemUI/compose/features/src/com/android/systemui/communal/ui/compose/CommunalHub.kt2
1 files changed, 0 insertions, 2 deletions
diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/communal/ui/compose/CommunalHub.kt b/packages/SystemUI/compose/features/src/com/android/systemui/communal/ui/compose/CommunalHub.kt
index c80902e22a56..d822d1996eff 100644
--- a/packages/SystemUI/compose/features/src/com/android/systemui/communal/ui/compose/CommunalHub.kt
+++ b/packages/SystemUI/compose/features/src/com/android/systemui/communal/ui/compose/CommunalHub.kt
@@ -146,8 +146,6 @@ private fun WidgetContent(
.createView(context, model.appWidgetId, model.providerInfo)
.apply { updateAppWidgetSize(Bundle.EMPTY, listOf(size)) }
},
- // For reusing composition in lazy lists.
- onReset = {}
)
}
}