diff options
| author | 2024-05-02 15:24:04 -0700 | |
|---|---|---|
| committer | 2024-05-02 16:04:46 -0700 | |
| commit | 96923a5a52f59c8e9c9a8306d3f1b2677c47e352 (patch) | |
| tree | 8d1f4925616425c3e1f7dd02f132290ce888d4f5 | |
| parent | 61500d560f5ffa4653d58d1bf829d25b7b56ee59 (diff) | |
[flexiglass] Wire durationScale properly for transition builders.
We weren't passing in the durationScale and/or were overriding it inside
another function inside the main function.
Test: manually verified that Flexiglass scene transitions when locked
and unlocked still look correct.
Flag: ACONFIG com.android.systemui.scene_container DEVELOPMENT
Bug: 330672236
Change-Id: Ic9b01ed8fa2bbe4edd0ad75e9e9a854709bd10dd
5 files changed, 11 insertions, 21 deletions
diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/SceneContainerTransitions.kt b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/SceneContainerTransitions.kt index 4c656b033408..6bd4cf932770 100644 --- a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/SceneContainerTransitions.kt +++ b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/SceneContainerTransitions.kt @@ -44,6 +44,13 @@ val SceneContainerTransitions = transitions { } from( Scenes.Gone, + to = Scenes.QuickSettings, + key = CollapseShadeInstantly, + ) { + goneToQuickSettingsTransition(durationScale = 0.0) + } + from( + Scenes.Gone, to = Scenes.Shade, key = SlightlyFasterShadeCollapse, ) { diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToQuickSettingsTransition.kt b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToQuickSettingsTransition.kt index 851719d387f5..918e1ad795c4 100644 --- a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToQuickSettingsTransition.kt +++ b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToQuickSettingsTransition.kt @@ -1,14 +1,12 @@ package com.android.systemui.scene.ui.composable.transitions -import androidx.compose.animation.core.tween import com.android.compose.animation.scene.TransitionBuilder import kotlin.time.Duration.Companion.milliseconds fun TransitionBuilder.goneToQuickSettingsTransition( durationScale: Double = 1.0, ) { - spec = tween(durationMillis = (DefaultDuration * durationScale).inWholeMilliseconds.toInt()) - toQuickSettingsTransition() + toQuickSettingsTransition(durationScale = durationScale) } private val DefaultDuration = 500.milliseconds diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToShadeTransition.kt b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToShadeTransition.kt index a0f410ab27fb..d3ef27372435 100644 --- a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToShadeTransition.kt +++ b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromGoneToShadeTransition.kt @@ -1,14 +1,9 @@ package com.android.systemui.scene.ui.composable.transitions -import androidx.compose.animation.core.tween import com.android.compose.animation.scene.TransitionBuilder -import kotlin.time.Duration.Companion.milliseconds fun TransitionBuilder.goneToShadeTransition( durationScale: Double = 1.0, ) { - spec = tween(durationMillis = (DefaultDuration * durationScale).inWholeMilliseconds.toInt()) - toShadeTransition() + toShadeTransition(durationScale = durationScale) } - -private val DefaultDuration = 500.milliseconds diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToQuickSettingsTransition.kt b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToQuickSettingsTransition.kt index 319438c256dd..ba30a859f4e0 100644 --- a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToQuickSettingsTransition.kt +++ b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToQuickSettingsTransition.kt @@ -1,14 +1,9 @@ package com.android.systemui.scene.ui.composable.transitions -import androidx.compose.animation.core.tween import com.android.compose.animation.scene.TransitionBuilder -import kotlin.time.Duration.Companion.milliseconds fun TransitionBuilder.lockscreenToQuickSettingsTransition( durationScale: Double = 1.0, ) { - spec = tween(durationMillis = (DefaultDuration * durationScale).inWholeMilliseconds.toInt()) - toQuickSettingsTransition() + toQuickSettingsTransition(durationScale = durationScale) } - -private val DefaultDuration = 500.milliseconds diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToShadeTransition.kt b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToShadeTransition.kt index f078b8c9b78b..2aded0db3c37 100644 --- a/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToShadeTransition.kt +++ b/packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/transitions/FromLockscreenToShadeTransition.kt @@ -1,14 +1,9 @@ package com.android.systemui.scene.ui.composable.transitions -import androidx.compose.animation.core.tween import com.android.compose.animation.scene.TransitionBuilder -import kotlin.time.Duration.Companion.milliseconds fun TransitionBuilder.lockscreenToShadeTransition( durationScale: Double = 1.0, ) { - spec = tween(durationMillis = (DefaultDuration * durationScale).inWholeMilliseconds.toInt()) - toShadeTransition() + toShadeTransition(durationScale = durationScale) } - -private val DefaultDuration = 500.milliseconds |