summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Angela Wang <angelala@google.com> 2023-03-02 01:53:27 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2023-03-02 01:53:27 +0000
commit95d82c46cfec0abb3563a4b8a71258d993aeb0ce (patch)
treea3a5f351d2dea8015a5b4d6ccd5f385308001a0d
parent02069e3fe3149e32b45028418304037766098231 (diff)
parentb1478ce882cb88ebc85c90bec18a8abf8b61c47f (diff)
Merge "Applies feature flag on Flash Notifications" into udc-dev
-rw-r--r--core/java/android/util/FeatureFlagUtils.java6
-rw-r--r--services/accessibility/java/com/android/server/accessibility/FlashNotificationsController.java7
2 files changed, 8 insertions, 5 deletions
diff --git a/core/java/android/util/FeatureFlagUtils.java b/core/java/android/util/FeatureFlagUtils.java
index a746dc6c15f0..2ae882c81b50 100644
--- a/core/java/android/util/FeatureFlagUtils.java
+++ b/core/java/android/util/FeatureFlagUtils.java
@@ -164,10 +164,10 @@ public class FeatureFlagUtils {
*/
public static final String SETTINGS_AUDIO_ROUTING = "settings_audio_routing";
- /** Flag to enable/disable flash alerts
+ /** Flag to enable/disable flash notifications
* @hide
*/
- public static final String SETTINGS_FLASH_ALERTS = "settings_flash_alerts";
+ public static final String SETTINGS_FLASH_NOTIFICATIONS = "settings_flash_notifications";
/**
* Flag to disable/enable showing udfps enroll view in settings. If it's disabled, udfps enroll
@@ -232,7 +232,7 @@ public class FeatureFlagUtils {
DEFAULT_FLAGS.put(SETTINGS_ACCESSIBILITY_HEARING_AID_PAGE, "false");
DEFAULT_FLAGS.put(SETTINGS_PREFER_ACCESSIBILITY_MENU_IN_SYSTEM, "false");
DEFAULT_FLAGS.put(SETTINGS_AUDIO_ROUTING, "false");
- DEFAULT_FLAGS.put(SETTINGS_FLASH_ALERTS, "false");
+ DEFAULT_FLAGS.put(SETTINGS_FLASH_NOTIFICATIONS, "true");
DEFAULT_FLAGS.put(SETTINGS_SHOW_UDFPS_ENROLL_IN_SETTINGS, "true");
DEFAULT_FLAGS.put(SETTINGS_ENABLE_LOCKSCREEN_TRANSFER_API, "false");
DEFAULT_FLAGS.put(SETTINGS_REMOTE_DEVICE_CREDENTIAL_VALIDATION, "false");
diff --git a/services/accessibility/java/com/android/server/accessibility/FlashNotificationsController.java b/services/accessibility/java/com/android/server/accessibility/FlashNotificationsController.java
index 86b5a12f3c47..a94ab34bc8b3 100644
--- a/services/accessibility/java/com/android/server/accessibility/FlashNotificationsController.java
+++ b/services/accessibility/java/com/android/server/accessibility/FlashNotificationsController.java
@@ -53,6 +53,7 @@ import android.os.RemoteException;
import android.os.SystemClock;
import android.os.UserHandle;
import android.provider.Settings;
+import android.util.FeatureFlagUtils;
import android.util.Log;
import android.view.Display;
import android.view.View;
@@ -342,10 +343,12 @@ class FlashNotificationsController {
private void requestStartFlashNotification(FlashNotification flashNotification) {
if (DEBUG) Log.d(LOG_TAG, "requestStartFlashNotification");
- mIsCameraFlashNotificationEnabled = Settings.System.getIntForUser(
+ boolean isFeatureOn = FeatureFlagUtils.isEnabled(mContext,
+ FeatureFlagUtils.SETTINGS_FLASH_NOTIFICATIONS);
+ mIsCameraFlashNotificationEnabled = isFeatureOn && Settings.System.getIntForUser(
mContext.getContentResolver(), SETTING_KEY_CAMERA_FLASH_NOTIFICATION, 0,
UserHandle.USER_CURRENT) != 0;
- mIsScreenFlashNotificationEnabled = Settings.System.getIntForUser(
+ mIsScreenFlashNotificationEnabled = isFeatureOn && Settings.System.getIntForUser(
mContext.getContentResolver(), SETTING_KEY_SCREEN_FLASH_NOTIFICATION, 0,
UserHandle.USER_CURRENT) != 0;