summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Svetoslav Ganov <svetoslavganov@google.com> 2020-06-24 17:01:41 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2020-06-24 17:01:41 +0000
commit9529f00aa7b2f85adc2071d03b2ae632648fadfa (patch)
treebd7ed69320bb9f54f2b2d56c8a25fe26212f1512
parent308851ebdec034fe9c166b321757328255ab1af8 (diff)
parentdab5588e84d6ff95b6514493d897f450672c9c0e (diff)
Merge "Address missed comments from previous CL" into rvc-dev am: dab5588e84
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11978216 Change-Id: I2637826dde356b7604dffa907f4385c7b83a3780
-rw-r--r--core/java/android/view/SurfaceControl.java2
-rw-r--r--core/java/android/view/SurfaceView.java2
-rw-r--r--core/java/android/widget/inline/InlineContentView.java3
3 files changed, 3 insertions, 4 deletions
diff --git a/core/java/android/view/SurfaceControl.java b/core/java/android/view/SurfaceControl.java
index 73d218057707..7150afe68d40 100644
--- a/core/java/android/view/SurfaceControl.java
+++ b/core/java/android/view/SurfaceControl.java
@@ -229,7 +229,7 @@ public final class SurfaceControl implements Parcelable {
int transformHint);
@Nullable
- @GuardedBy("sLock")
+ @GuardedBy("mLock")
private ArrayList<OnReparentListener> mReparentListeners;
/**
diff --git a/core/java/android/view/SurfaceView.java b/core/java/android/view/SurfaceView.java
index 5b6e5c1acea2..0d21eb5cf920 100644
--- a/core/java/android/view/SurfaceView.java
+++ b/core/java/android/view/SurfaceView.java
@@ -1231,7 +1231,7 @@ public class SurfaceView extends View implements ViewRootImpl.SurfaceChangedCall
float postScaleX, float postScaleY) {
transaction.setPosition(surface, positionLeft, positionTop);
transaction.setMatrix(surface, postScaleX /*dsdx*/, 0f /*dtdx*/,
- 0f /*dsdy*/, postScaleY /*dtdy*/);
+ 0f /*dtdy*/, postScaleY /*dsdy*/);
}
/** @hide */
diff --git a/core/java/android/widget/inline/InlineContentView.java b/core/java/android/widget/inline/InlineContentView.java
index be7c6966ce38..1b666aa67e90 100644
--- a/core/java/android/widget/inline/InlineContentView.java
+++ b/core/java/android/widget/inline/InlineContentView.java
@@ -156,8 +156,7 @@ public class InlineContentView extends ViewGroup {
@Override
public void onDraw() {
computeParentPositionAndScale();
- final int visibility = InlineContentView.this.isShown() ? VISIBLE : GONE;
- mSurfaceView.setVisibility(visibility);
+ mSurfaceView.setVisibility(VISIBLE);
}
};