summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jean Chalard <jchalard@google.com> 2023-08-04 06:09:09 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2023-08-04 06:09:09 +0000
commit93c7b643d5d2a581b4881a57e9efc7297d49abf3 (patch)
treee87a88dd9758c4b64e4a0e452e7348e138c6c9c9
parentfd589b47778cfefdcea6da8f75f4654e2973081c (diff)
parentf705f5a1d661a58c49fe1d32c36b35a35aa13e3e (diff)
Merge "Document limitations of the VpnService setHttpProxy API" into main
-rw-r--r--core/java/android/net/VpnService.java11
1 files changed, 9 insertions, 2 deletions
diff --git a/core/java/android/net/VpnService.java b/core/java/android/net/VpnService.java
index 1ae1b050d32f..37bd67a4b883 100644
--- a/core/java/android/net/VpnService.java
+++ b/core/java/android/net/VpnService.java
@@ -537,8 +537,15 @@ public class VpnService extends Service {
}
/**
- * Sets an HTTP proxy for the VPN network. This proxy is only a recommendation
- * and it is possible that some apps will ignore it. PAC proxies are not supported.
+ * Sets an HTTP proxy for the VPN network.
+ * <p class="note">This proxy is only a recommendation and it is possible that some apps
+ * will ignore it.
+ * <p class="note">PAC proxies are not supported over VPNs.
+ * <p class="note">Apps that do use the proxy cannot distinguish between routes handled
+ * and not handled by the VPN and will try to access HTTP resources over the proxy
+ * regardless of the destination. In practice this means using a proxy with a split
+ * tunnel generally won't work as expected, because HTTP accesses on routes not handled by
+ * the VPN will not reach as the proxy won't be available outside of the VPN network.
*/
@NonNull
public Builder setHttpProxy(@NonNull ProxyInfo proxyInfo) {