summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author TreeHugger Robot <treehugger-gerrit@google.com> 2020-04-10 07:14:27 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2020-04-10 07:14:27 +0000
commit93b7e70d9f670f38875a5629f09fa3c0972b9df2 (patch)
tree442ae4c4df76b035b89e1424868173ed3d5d91df
parent926a6d7a334c9c572bcf3afc1cced943fc8fe48e (diff)
parent6c89d1e310c1b0ff74d2af1a1ce13154f60c09f2 (diff)
Merge "Controls a11y - Fix title repetition, min height" into rvc-dev
-rw-r--r--packages/SystemUI/res/layout/controls_spinner_item.xml1
-rw-r--r--packages/SystemUI/res/layout/controls_with_favorites.xml2
-rw-r--r--packages/SystemUI/src/com/android/systemui/controls/ui/ControlsUiControllerImpl.kt2
3 files changed, 3 insertions, 2 deletions
diff --git a/packages/SystemUI/res/layout/controls_spinner_item.xml b/packages/SystemUI/res/layout/controls_spinner_item.xml
index 00654c832525..45540f102de1 100644
--- a/packages/SystemUI/res/layout/controls_spinner_item.xml
+++ b/packages/SystemUI/res/layout/controls_spinner_item.xml
@@ -30,6 +30,7 @@
android:layout_gravity="center"
android:layout_width="@dimen/controls_header_app_icon_size"
android:layout_height="@dimen/controls_header_app_icon_size"
+ android:contentDescription="@null"
android:layout_marginEnd="10dp" />
<TextView
diff --git a/packages/SystemUI/res/layout/controls_with_favorites.xml b/packages/SystemUI/res/layout/controls_with_favorites.xml
index 623f2a0d3423..b32320956e26 100644
--- a/packages/SystemUI/res/layout/controls_with_favorites.xml
+++ b/packages/SystemUI/res/layout/controls_with_favorites.xml
@@ -34,6 +34,7 @@
android:orientation="horizontal"
android:layout_width="0dp"
android:layout_weight="1"
+ android:minHeight="48dp"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:gravity="center">
@@ -43,6 +44,7 @@
android:layout_gravity="center"
android:layout_width="@dimen/controls_header_app_icon_size"
android:layout_height="@dimen/controls_header_app_icon_size"
+ android:contentDescription="@null"
android:layout_marginEnd="10dp" />
<TextView
diff --git a/packages/SystemUI/src/com/android/systemui/controls/ui/ControlsUiControllerImpl.kt b/packages/SystemUI/src/com/android/systemui/controls/ui/ControlsUiControllerImpl.kt
index 934a69508d68..7da3d70271c1 100644
--- a/packages/SystemUI/src/com/android/systemui/controls/ui/ControlsUiControllerImpl.kt
+++ b/packages/SystemUI/src/com/android/systemui/controls/ui/ControlsUiControllerImpl.kt
@@ -361,7 +361,6 @@ class ControlsUiControllerImpl @Inject constructor (
.setTint(context.resources.getColor(R.color.control_spinner_dropdown, null))
}
parent.requireViewById<ImageView>(R.id.app_icon).apply {
- setContentDescription(selectionItem.getTitle())
setImageDrawable(selectionItem.icon)
}
@@ -586,7 +585,6 @@ private class ItemAdapter(
setText(item.getTitle())
}
view.requireViewById<ImageView>(R.id.app_icon).apply {
- setContentDescription(item.appName)
setImageDrawable(item.icon)
}
return view