diff options
| author | 2020-02-17 07:29:45 +0000 | |
|---|---|---|
| committer | 2020-02-17 07:29:45 +0000 | |
| commit | 92d21839f38a789e2bbe60454b2eb43f4065d051 (patch) | |
| tree | 6f17a6a0c88e21cc079419b4b003f927cc0cb203 | |
| parent | 601847e5b95146ca81052a7c39e138442a652046 (diff) | |
| parent | 0f64b3cf0a2a8d5cebd89d9ce49a51f93fa49df4 (diff) | |
Merge "Remove FLAG_SHOW_FOR_ALL_USERS to avoid crash in a11y"
2 files changed, 4 insertions, 5 deletions
diff --git a/core/java/com/android/internal/accessibility/AccessibilityShortcutController.java b/core/java/com/android/internal/accessibility/AccessibilityShortcutController.java index a1c22e9994c8..bb404654b741 100644 --- a/core/java/com/android/internal/accessibility/AccessibilityShortcutController.java +++ b/core/java/com/android/internal/accessibility/AccessibilityShortcutController.java @@ -262,8 +262,6 @@ public class AccessibilityShortcutController { String toastMessage = String.format(toastMessageFormatString, serviceName); Toast warningToast = mFrameworkObjectProvider.makeToastFromText( mContext, toastMessage, Toast.LENGTH_LONG); - warningToast.getWindowParams().privateFlags |= - WindowManager.LayoutParams.SYSTEM_FLAG_SHOW_FOR_ALL_USERS; warningToast.show(); } diff --git a/core/tests/coretests/src/com/android/internal/accessibility/AccessibilityShortcutControllerTest.java b/core/tests/coretests/src/com/android/internal/accessibility/AccessibilityShortcutControllerTest.java index 6784ede5b5da..bbf3b12d9b7d 100644 --- a/core/tests/coretests/src/com/android/internal/accessibility/AccessibilityShortcutControllerTest.java +++ b/core/tests/coretests/src/com/android/internal/accessibility/AccessibilityShortcutControllerTest.java @@ -362,9 +362,10 @@ public class AccessibilityShortcutControllerTest { accessibilityShortcutController.performAccessibilityShortcut(); accessibilityShortcutController.performAccessibilityShortcut(); verify(mToast).show(); - assertEquals(WindowManager.LayoutParams.SYSTEM_FLAG_SHOW_FOR_ALL_USERS, - mLayoutParams.privateFlags - & WindowManager.LayoutParams.SYSTEM_FLAG_SHOW_FOR_ALL_USERS); + // TODO(b/149408635): Reintroduce assertion + // assertEquals(WindowManager.LayoutParams.SYSTEM_FLAG_SHOW_FOR_ALL_USERS, + // mLayoutParams.privateFlags + // & WindowManager.LayoutParams.SYSTEM_FLAG_SHOW_FOR_ALL_USERS); verify(mAccessibilityManagerService, times(1)).performAccessibilityShortcut(null); } |