diff options
| author | 2019-03-07 12:35:59 +0000 | |
|---|---|---|
| committer | 2019-03-07 12:38:53 +0000 | |
| commit | 910bca33d481f4dfd466aa2b1478c7edeede63ff (patch) | |
| tree | 200fbecd19c127e9b4133c11def84beabb6ebd8a | |
| parent | 46835775cf518ee44408e040353da6e828a6fbce (diff) | |
Use updated DeviceConfig API's getInt method to simplify invocation.
Test: atest AutofillManagerServiceTest
Change-Id: I7efd66bb495fd22298d9a24fcb5c33b8be785b23
| -rw-r--r-- | services/autofill/java/com/android/server/autofill/AutofillManagerService.java | 9 | ||||
| -rw-r--r-- | services/autofill/java/com/android/server/autofill/Helper.java | 17 |
2 files changed, 6 insertions, 20 deletions
diff --git a/services/autofill/java/com/android/server/autofill/AutofillManagerService.java b/services/autofill/java/com/android/server/autofill/AutofillManagerService.java index 245e2c990ee3..0e852f8c5c48 100644 --- a/services/autofill/java/com/android/server/autofill/AutofillManagerService.java +++ b/services/autofill/java/com/android/server/autofill/AutofillManagerService.java @@ -479,13 +479,16 @@ public final class AutofillManagerService private void setDeviceConfigProperties() { synchronized (mLock) { - mAugmentedServiceIdleUnbindTimeoutMs = Helper.getIntDeviceConfigProperty( + mAugmentedServiceIdleUnbindTimeoutMs = DeviceConfig.getInt( + DeviceConfig.NAMESPACE_AUTOFILL, AutofillManager.DEVICE_CONFIG_AUGMENTED_SERVICE_IDLE_UNBIND_TIMEOUT, (int) AbstractRemoteService.PERMANENT_BOUND_TIMEOUT_MS); - mAugmentedServiceRequestTimeoutMs = Helper.getIntDeviceConfigProperty( + mAugmentedServiceRequestTimeoutMs = DeviceConfig.getInt( + DeviceConfig.NAMESPACE_AUTOFILL, AutofillManager.DEVICE_CONFIG_AUGMENTED_SERVICE_REQUEST_TIMEOUT, DEFAULT_AUGMENTED_AUTOFILL_REQUEST_TIMEOUT_MILLIS); - mSupportedSmartSuggestionModes = Helper.getIntDeviceConfigProperty( + mSupportedSmartSuggestionModes = DeviceConfig.getInt( + DeviceConfig.NAMESPACE_AUTOFILL, AutofillManager.DEVICE_CONFIG_AUTOFILL_SMART_SUGGESTION_SUPPORTED_MODES, AutofillManager.FLAG_SMART_SUGGESTION_SYSTEM); if (verbose) { diff --git a/services/autofill/java/com/android/server/autofill/Helper.java b/services/autofill/java/com/android/server/autofill/Helper.java index d300bf210e8a..3c0da7d2d388 100644 --- a/services/autofill/java/com/android/server/autofill/Helper.java +++ b/services/autofill/java/com/android/server/autofill/Helper.java @@ -22,11 +22,9 @@ import android.app.assist.AssistStructure; import android.app.assist.AssistStructure.ViewNode; import android.content.ComponentName; import android.metrics.LogMaker; -import android.provider.DeviceConfig; import android.service.autofill.Dataset; import android.util.ArrayMap; import android.util.ArraySet; -import android.util.Log; import android.util.Slog; import android.view.WindowManager; import android.view.autofill.AutofillId; @@ -207,21 +205,6 @@ public final class Helper { } } - /** - * Gets the value of a device config property from the Autofill namespace. - */ - static int getIntDeviceConfigProperty(@NonNull String key, int defaultValue) { - final String value = DeviceConfig.getProperty(DeviceConfig.NAMESPACE_AUTOFILL, key); - if (value == null) return defaultValue; - - try { - return Integer.parseInt(value); - } catch (Exception e) { - Log.w(TAG, "error parsing value (" + value + ") of property " + key + ": " + e); - return defaultValue; - } - } - private interface ViewNodeFilter { boolean matches(ViewNode node); } |