diff options
| author | 2024-08-30 14:41:00 +0200 | |
|---|---|---|
| committer | 2024-09-02 16:40:12 +0000 | |
| commit | 90191232ddfc9a0fbcbb401af33b49dafb2d99f8 (patch) | |
| tree | 16995c98897059eb2876880e4bfae07ea4d84a43 | |
| parent | 8755f8ea491357425183e19e7adafd29673539a2 (diff) | |
[flexiglass] Remove layoutMinHeight uses
Test: manually tested that HUNs look okay, including when the QS panel
is fully expanded
Flag: com.android.systemui.scene_container
Bug: 360106096
Change-Id: I339028e34b6f2c429f5b58bb4330145348364c1d
2 files changed, 15 insertions, 4 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/AmbientState.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/AmbientState.java index 2f3719a34ac8..1431b28bf794 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/AmbientState.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/AmbientState.java @@ -533,8 +533,15 @@ public class AmbientState implements Dumpable { if (mDozeAmount == 1.0f && !isPulseExpanding()) { return mShelf.getHeight(); } - int height = (int) Math.max(mLayoutMinHeight, - Math.min(mLayoutHeight, mContentHeight) - mTopPadding); + int height; + if (SceneContainerFlag.isEnabled()) { + // TODO(b/192348384): This is probably incorrect as mContentHeight is not up to date. + // Consider removing usages of getInnerHeight in flexiglass if possible. + height = (int) Math.min(mLayoutHeight, mContentHeight) - mTopPadding; + } else { + height = (int) Math.max(mLayoutMinHeight, + Math.min(mLayoutHeight, mContentHeight) - mTopPadding); + } if (ignorePulseHeight) { return height; } @@ -571,6 +578,7 @@ public class AmbientState implements Dumpable { } public void setLayoutMinHeight(int layoutMinHeight) { + SceneContainerFlag.assertInLegacyMode(); mLayoutMinHeight = layoutMinHeight; } diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java b/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java index 925ebf30cf7b..cea7561819a2 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java @@ -1308,8 +1308,10 @@ public class NotificationStackScrollLayout } private void updateAlgorithmLayoutMinHeight() { - mAmbientState.setLayoutMinHeight(mQsFullScreen || isHeadsUpTransition() - ? getLayoutMinHeightInternal() : 0); + if (!SceneContainerFlag.isEnabled()) { + mAmbientState.setLayoutMinHeight(mQsFullScreen || isHeadsUpTransition() + ? getLayoutMinHeightInternal() : 0); + } } /** @@ -2795,6 +2797,7 @@ public class NotificationStackScrollLayout } private int getLayoutMinHeightInternal() { + SceneContainerFlag.assertInLegacyMode(); if (isHeadsUpTransition()) { ExpandableNotificationRow trackedHeadsUpRow = mAmbientState.getTrackedHeadsUpRow(); if (trackedHeadsUpRow.isAboveShelf()) { |