diff options
| author | 2018-12-11 01:00:09 -0800 | |
|---|---|---|
| committer | 2019-01-31 00:48:20 -0800 | |
| commit | 8de43ee1217ef639a616cbd850bc486f1f1e8da5 (patch) | |
| tree | 726ff1ab2c9f26728137210cb112e513caa2c9bf | |
| parent | ed02ce4f19bfe2285177eb81a12cba01aa8dbfbd (diff) | |
Resolve feedback from API review
Fix inconsistent naming of offline license states
bug:120489407
bug:120488811
test:cts and gts media tests
Change-Id: I6cceac233cf8882c5bf7fbef7503764c611125d1
| -rw-r--r-- | api/current.txt | 4 | ||||
| -rw-r--r-- | media/java/android/media/MediaDrm.java | 16 | ||||
| -rw-r--r-- | media/jni/android_media_MediaDrm.cpp | 12 |
3 files changed, 16 insertions, 16 deletions
diff --git a/api/current.txt b/api/current.txt index 6b8854779d31..011f849b6525 100644 --- a/api/current.txt +++ b/api/current.txt @@ -24727,9 +24727,9 @@ package android.media { field public static final int KEY_TYPE_OFFLINE = 2; // 0x2 field public static final int KEY_TYPE_RELEASE = 3; // 0x3 field public static final int KEY_TYPE_STREAMING = 1; // 0x1 - field public static final int OFFLINE_LICENSE_INACTIVE = 2; // 0x2 + field public static final int OFFLINE_LICENSE_STATE_RELEASED = 2; // 0x2 field public static final int OFFLINE_LICENSE_STATE_UNKNOWN = 0; // 0x0 - field public static final int OFFLINE_LICENSE_USABLE = 1; // 0x1 + field public static final int OFFLINE_LICENSE_STATE_USABLE = 1; // 0x1 field public static final String PROPERTY_ALGORITHMS = "algorithms"; field public static final String PROPERTY_DESCRIPTION = "description"; field public static final String PROPERTY_DEVICE_UNIQUE_ID = "deviceUniqueId"; diff --git a/media/java/android/media/MediaDrm.java b/media/java/android/media/MediaDrm.java index 2d2c4a80bbf0..9258b85395d6 100644 --- a/media/java/android/media/MediaDrm.java +++ b/media/java/android/media/MediaDrm.java @@ -1186,22 +1186,22 @@ public final class MediaDrm implements AutoCloseable { public static final int OFFLINE_LICENSE_STATE_UNKNOWN = 0; /** - * Offline license state is usable, the keys may be used for decryption. + * Offline license is usable, the keys may be used for decryption. */ - public static final int OFFLINE_LICENSE_USABLE = 1; + public static final int OFFLINE_LICENSE_STATE_USABLE = 1; /** - * Offline license state is inactive, the keys have been marked for - * release using {@link #getKeyRequest} with KEY_TYPE_RELEASE but the - * key response has not been received. + * Offline license is released, the keys have been marked for + * release using {@link #getKeyRequest} with KEY_TYPE_RELEASE but + * the key response has not been received. */ - public static final int OFFLINE_LICENSE_INACTIVE = 2; + public static final int OFFLINE_LICENSE_STATE_RELEASED = 2; /** @hide */ @IntDef({ OFFLINE_LICENSE_STATE_UNKNOWN, - OFFLINE_LICENSE_USABLE, - OFFLINE_LICENSE_INACTIVE, + OFFLINE_LICENSE_STATE_USABLE, + OFFLINE_LICENSE_STATE_RELEASED, }) @Retention(RetentionPolicy.SOURCE) public @interface OfflineLicenseState {} diff --git a/media/jni/android_media_MediaDrm.cpp b/media/jni/android_media_MediaDrm.cpp index 866325c5ea9c..d7ab854d63ba 100644 --- a/media/jni/android_media_MediaDrm.cpp +++ b/media/jni/android_media_MediaDrm.cpp @@ -175,7 +175,7 @@ struct SecurityLevels { struct OfflineLicenseState { jint kOfflineLicenseStateUsable; - jint kOfflineLicenseStateInactive; + jint kOfflineLicenseStateReleased; jint kOfflineLicenseStateUnknown; } gOfflineLicenseStates; @@ -797,10 +797,10 @@ static void android_media_MediaDrm_native_init(JNIEnv *env) { GET_STATIC_FIELD_ID(field, clazz, "SECURITY_LEVEL_HW_SECURE_ALL", "I"); gSecurityLevels.kSecurityLevelHwSecureAll = env->GetStaticIntField(clazz, field); - GET_STATIC_FIELD_ID(field, clazz, "OFFLINE_LICENSE_USABLE", "I"); + GET_STATIC_FIELD_ID(field, clazz, "OFFLINE_LICENSE_STATE_USABLE", "I"); gOfflineLicenseStates.kOfflineLicenseStateUsable = env->GetStaticIntField(clazz, field); - GET_STATIC_FIELD_ID(field, clazz, "OFFLINE_LICENSE_INACTIVE", "I"); - gOfflineLicenseStates.kOfflineLicenseStateInactive = env->GetStaticIntField(clazz, field); + GET_STATIC_FIELD_ID(field, clazz, "OFFLINE_LICENSE_STATE_RELEASED", "I"); + gOfflineLicenseStates.kOfflineLicenseStateReleased = env->GetStaticIntField(clazz, field); GET_STATIC_FIELD_ID(field, clazz, "OFFLINE_LICENSE_STATE_UNKNOWN", "I"); gOfflineLicenseStates.kOfflineLicenseStateUnknown = env->GetStaticIntField(clazz, field); @@ -1581,8 +1581,8 @@ static jint android_media_MediaDrm_getOfflineLicenseState(JNIEnv *env, switch(state) { case DrmPlugin::kOfflineLicenseStateUsable: return gOfflineLicenseStates.kOfflineLicenseStateUsable; - case DrmPlugin::kOfflineLicenseStateInactive: - return gOfflineLicenseStates.kOfflineLicenseStateInactive; + case DrmPlugin::kOfflineLicenseStateReleased: + return gOfflineLicenseStates.kOfflineLicenseStateReleased; default: return gOfflineLicenseStates.kOfflineLicenseStateUnknown; } |