summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author android-build-team Robot <android-build-team-robot@google.com> 2018-05-09 16:55:26 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2018-05-09 16:55:26 +0000
commit8d6571aeede9fa0fe17ff72d4105afc8320fd9f1 (patch)
tree2977c8d445ed9c7b5f169c16dca152636b0c65e4
parentd99e347f39795d1be40e667ece531d961bfcc0db (diff)
parentf28bec4150dc3c4e85c5991f2ea97cc3b2419032 (diff)
Merge changes I5851dd16,Id196307f into pi-dev
* changes: OMS: harden permission checks Add missing fields to OverlayInfo.hashCode
-rw-r--r--core/java/android/content/om/OverlayInfo.java1
-rw-r--r--services/core/java/com/android/server/om/OverlayManagerService.java5
2 files changed, 3 insertions, 3 deletions
diff --git a/core/java/android/content/om/OverlayInfo.java b/core/java/android/content/om/OverlayInfo.java
index 6e63342698b3..a10cc120ad6c 100644
--- a/core/java/android/content/om/OverlayInfo.java
+++ b/core/java/android/content/om/OverlayInfo.java
@@ -261,6 +261,7 @@ public final class OverlayInfo implements Parcelable {
result = prime * result + state;
result = prime * result + ((packageName == null) ? 0 : packageName.hashCode());
result = prime * result + ((targetPackageName == null) ? 0 : targetPackageName.hashCode());
+ result = prime * result + ((category == null) ? 0 : category.hashCode());
result = prime * result + ((baseCodePath == null) ? 0 : baseCodePath.hashCode());
return result;
}
diff --git a/services/core/java/com/android/server/om/OverlayManagerService.java b/services/core/java/com/android/server/om/OverlayManagerService.java
index 8562572c3c39..a6dfec7821b6 100644
--- a/services/core/java/com/android/server/om/OverlayManagerService.java
+++ b/services/core/java/com/android/server/om/OverlayManagerService.java
@@ -680,7 +680,7 @@ public final class OverlayManagerService extends SystemService {
* @throws SecurityException if the permission check fails
*/
private void enforceChangeOverlayPackagesPermission(@NonNull final String message) {
- getContext().enforceCallingOrSelfPermission(
+ getContext().enforceCallingPermission(
android.Manifest.permission.CHANGE_OVERLAY_PACKAGES, message);
}
@@ -691,8 +691,7 @@ public final class OverlayManagerService extends SystemService {
* @throws SecurityException if the permission check fails
*/
private void enforceDumpPermission(@NonNull final String message) {
- getContext().enforceCallingOrSelfPermission(android.Manifest.permission.DUMP,
- message);
+ getContext().enforceCallingPermission(android.Manifest.permission.DUMP, message);
}
};