summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yohei Yukawa <yukawa@google.com> 2019-01-21 00:18:28 -0800
committer Yohei Yukawa <yukawa@google.com> 2019-01-21 00:18:28 -0800
commit8d1592e30766e6c1bd0f2950ff23becb66386817 (patch)
treebcda5df7c01694a70a3f1417e6550a8e7bafaa24
parent9b60ba07e4f17d0cb0f466eb2e3b3ad7e8326aad (diff)
Inline InputMethodManagerService#updateSystemUi()
This method is already called after locking with IMMS#mMethodMap. Hence this method can be safely inlined. This is a mechanical refactoring. There should be no behavior change. Bug: 34851776 Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases Change-Id: I50f8670b090183d29beebb3f26fd3238d93d41c5
-rw-r--r--services/core/java/com/android/server/inputmethod/InputMethodManagerService.java8
1 files changed, 1 insertions, 7 deletions
diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
index 0c65a8aec567..a24373e18c7e 100644
--- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
@@ -2446,12 +2446,6 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
(vis & InputMethodService.IME_VISIBLE) != 0, dismissImeOnBackKeyPressed);
}
- private void updateSystemUi(IBinder token, int vis, int backDisposition) {
- synchronized (mMethodMap) {
- updateSystemUiLocked(token, vis, backDisposition);
- }
- }
-
@BinderThread
private void reportStartInput(IBinder token, IBinder startInputToken) {
synchronized (mMethodMap) {
@@ -4049,7 +4043,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
attrs.privateFlags |= PRIVATE_FLAG_SHOW_FOR_ALL_USERS;
attrs.setTitle("Select input method");
w.setAttributes(attrs);
- updateSystemUi(mCurToken, mImeWindowVis, mBackDisposition);
+ updateSystemUiLocked(mCurToken, mImeWindowVis, mBackDisposition);
mSwitchingDialog.show();
}
}