diff options
| author | 2017-10-25 02:24:45 +0000 | |
|---|---|---|
| committer | 2017-10-25 02:24:45 +0000 | |
| commit | 8c69e67acd9e8d369e4eedf4ab41059226453926 (patch) | |
| tree | 1368cfb01e546027dc0842619a46fed7269e8b12 | |
| parent | 09947c53e0b05ee35fde747c3f97d82f7619570e (diff) | |
| parent | fd05e9a0750e9658989f49fbf51fd1fefbe466b3 (diff) | |
Merge "HIDL Java getService now the same as C++." am: 0c41ad872f am: 34b5b69de9
am: fd05e9a075
Change-Id: I6e55ca21bf55f3fe581eaceabc371dc0b85260ad
| -rw-r--r-- | core/java/android/os/HwBinder.java | 3 | ||||
| -rw-r--r-- | core/jni/android_os_HwBinder.cpp | 8 |
2 files changed, 6 insertions, 5 deletions
diff --git a/core/java/android/os/HwBinder.java b/core/java/android/os/HwBinder.java index 270e63f408a7..c1c65ffcc049 100644 --- a/core/java/android/os/HwBinder.java +++ b/core/java/android/os/HwBinder.java @@ -48,7 +48,8 @@ public abstract class HwBinder implements IHwBinder { public static native final IHwBinder getService( String iface, - String serviceName) + String serviceName, + boolean isTry) throws RemoteException, NoSuchElementException; public static native final void configureRpcThreadpool( diff --git a/core/jni/android_os_HwBinder.cpp b/core/jni/android_os_HwBinder.cpp index fe14d483743f..7fd97b232f07 100644 --- a/core/jni/android_os_HwBinder.cpp +++ b/core/jni/android_os_HwBinder.cpp @@ -303,7 +303,8 @@ static jobject JHwBinder_native_getService( JNIEnv *env, jclass /* clazzObj */, jstring ifaceNameObj, - jstring serviceNameObj) { + jstring serviceNameObj, + jboolean isTry) { using ::android::hidl::base::V1_0::IBase; using ::android::hardware::details::getRawServiceInternal; @@ -331,8 +332,7 @@ static jobject JHwBinder_native_getService( std::string serviceName(serviceNameCStr); env->ReleaseStringUTFChars(serviceNameObj, serviceNameCStr); - // TODO(b/67981006): true /* retry */ - sp<IBase> ret = getRawServiceInternal(ifaceName, serviceName, false /* retry */, false /* getStub */); + sp<IBase> ret = getRawServiceInternal(ifaceName, serviceName, !isTry /* retry */, false /* getStub */); sp<hardware::IBinder> service = hardware::toBinder<hidl::base::V1_0::IBase>(ret); if (service == NULL) { @@ -371,7 +371,7 @@ static JNINativeMethod gMethods[] = { { "registerService", "(Ljava/lang/String;)V", (void *)JHwBinder_native_registerService }, - { "getService", "(Ljava/lang/String;Ljava/lang/String;)L" PACKAGE_PATH "/IHwBinder;", + { "getService", "(Ljava/lang/String;Ljava/lang/String;Z)L" PACKAGE_PATH "/IHwBinder;", (void *)JHwBinder_native_getService }, { "configureRpcThreadpool", "(JZ)V", |