diff options
| author | 2019-10-25 17:58:53 +0000 | |
|---|---|---|
| committer | 2019-10-25 17:58:53 +0000 | |
| commit | 8aa567b7d97090626b92d592d4b2230ea9ef6119 (patch) | |
| tree | 08b4ef74dd5e7c433e80b923478b03899bb2fc64 | |
| parent | 52a3801810fb06e73d1be9874c892fefa6a1bdc2 (diff) | |
| parent | c6e015d6d6aa6132006886ffca375efb26eadae2 (diff) | |
Merge "Minor change on TODO comments"
| -rw-r--r-- | services/core/java/com/android/server/am/UserController.java | 4 | ||||
| -rw-r--r-- | services/core/java/com/android/server/pm/UserManagerService.java | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/services/core/java/com/android/server/am/UserController.java b/services/core/java/com/android/server/am/UserController.java index 175419117898..0ea913f340b0 100644 --- a/services/core/java/com/android/server/am/UserController.java +++ b/services/core/java/com/android/server/am/UserController.java @@ -560,8 +560,8 @@ class UserController implements Handler.Callback { Slog.i(TAG, "Stopping pre-created user " + userInfo.toFullString()); // Pre-created user was started right after creation so services could properly // intialize it; it should be stopped right away as it's not really a "real" user. - // TODO(b/140750212): in the long-term, we should add a onCreateUser() callback - // on SystemService instead. + // TODO(b/143092698): in the long-term, it might be better to add a onCreateUser() + // callback on SystemService instead. stopUser(userInfo.id, /* force= */ true, /* stopUserCallback= */ null, /* keyEvictedCallback= */ null); return; diff --git a/services/core/java/com/android/server/pm/UserManagerService.java b/services/core/java/com/android/server/pm/UserManagerService.java index cfc5ca0f11cd..4d2512c26422 100644 --- a/services/core/java/com/android/server/pm/UserManagerService.java +++ b/services/core/java/com/android/server/pm/UserManagerService.java @@ -2986,8 +2986,8 @@ public class UserManagerService extends IUserManager.Stub { // Must start user (which will be stopped right away, through // UserController.finishUserUnlockedCompleted) so services can properly // intialize it. - // TODO(b/140750212): in the long-term, we should add a onCreateUser() callback - // on SystemService instead. + // TODO(b/143092698): in the long-term, it might be better to add a onCreateUser() + // callback on SystemService instead. Slog.i(LOG_TAG, "starting pre-created user " + userInfo.toFullString()); final IActivityManager am = ActivityManager.getService(); try { @@ -3003,7 +3003,7 @@ public class UserManagerService extends IUserManager.Stub { Binder.restoreCallingIdentity(ident); } - // TODO(b/140750212): it's possible to reach "max users overflow" when the user is created + // TODO(b/143092698): it's possible to reach "max users overflow" when the user is created // "from scratch" (i.e., not from a pre-created user) and reaches the maximum number of // users without counting the pre-created one. Then when the pre-created is converted, the // "effective" number of max users is exceeds. Example: @@ -3048,7 +3048,7 @@ public class UserManagerService extends IUserManager.Stub { * <p>Should be used only during user creation, so the pre-created user can be used (instead of * creating and initializing a new user from scratch). */ - // TODO(b/140750212): add unit test + // TODO(b/143092698): add unit test @GuardedBy("mUsersLock") private @Nullable UserData getPreCreatedUserLU(@UserInfoFlag int flags) { if (DBG) { |