summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chalard Jean <jchalard@google.com> 2019-05-30 18:06:59 +0900
committer Chalard Jean <jchalard@google.com> 2019-05-30 18:10:01 +0900
commit8a0f055e75ea9a3bb0d69b8eed29e561b70dca06 (patch)
tree12cecc85491f426fd3b70ce12aeb46d29f3a667c
parent3ec6ba75097cf4d34d567e76f70221ce778f2af7 (diff)
Fix a comment
I need to learn to read Bug: 119216095 Test: comment-only change Change-Id: Ia2317fc146462e73c1c770ad0f6f2009e497649b
-rw-r--r--services/core/java/com/android/server/connectivity/Vpn.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/services/core/java/com/android/server/connectivity/Vpn.java b/services/core/java/com/android/server/connectivity/Vpn.java
index 6cac49d2a90b..e7a8b132d850 100644
--- a/services/core/java/com/android/server/connectivity/Vpn.java
+++ b/services/core/java/com/android/server/connectivity/Vpn.java
@@ -963,10 +963,11 @@ public class Vpn {
// VPN either provide a default route (IPv4 or IPv6 or both), or they are a split tunnel
// that falls back to the default network, which by definition provides INTERNET (unless
// there is no default network, in which case none of this matters in any sense).
- // Also, it guarantees that when a VPN applies to an app, the VPN will always be reported
- // as the network by getDefaultNetwork and registerDefaultNetworkCallback. This in turn
- // protects the invariant that apps calling CM#bindProcessToNetwork(getDefaultNetwork())
- // the same as if they use the default network.
+ // Also, always setting the INTERNET bit guarantees that when a VPN applies to an app,
+ // the VPN will always be reported as the network by getDefaultNetwork and callbacks
+ // registered with registerDefaultNetworkCallback. This in turn protects the invariant
+ // that an app calling ConnectivityManager#bindProcessToNetwork(getDefaultNetwork())
+ // behaves the same as when it uses the default network.
mNetworkCapabilities.addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET);
mNetworkInfo.setDetailedState(DetailedState.CONNECTING, null, null);