diff options
| author | 2018-04-24 12:24:03 -0700 | |
|---|---|---|
| committer | 2018-04-25 14:42:05 -0700 | |
| commit | 89d4cd4ece3bb972d5fd646c20b8c7a509d71f9d (patch) | |
| tree | 0caf02592d19b39b5992d52e021cd5d0d9307e43 | |
| parent | 8faa90beeb2e43cca7b245afc8f6e00b473f6eeb (diff) | |
Minor autofill logging improvements.
Bug: 77338392
Test: adb shell dumpsys autofill
Change-Id: I9c905077a4360667922efedb22060bde753fe68f
| -rw-r--r-- | services/autofill/java/com/android/server/autofill/FieldClassificationStrategy.java | 4 | ||||
| -rw-r--r-- | services/autofill/java/com/android/server/autofill/Session.java | 12 |
2 files changed, 6 insertions, 10 deletions
diff --git a/services/autofill/java/com/android/server/autofill/FieldClassificationStrategy.java b/services/autofill/java/com/android/server/autofill/FieldClassificationStrategy.java index da5220104e3c..5a7d4f654d5b 100644 --- a/services/autofill/java/com/android/server/autofill/FieldClassificationStrategy.java +++ b/services/autofill/java/com/android/server/autofill/FieldClassificationStrategy.java @@ -15,8 +15,6 @@ */ package com.android.server.autofill; -import static android.view.autofill.AutofillManager.FC_SERVICE_TIMEOUT; - import static com.android.server.autofill.Helper.sDebug; import static com.android.server.autofill.Helper.sVerbose; import static android.service.autofill.AutofillFieldClassificationService.SERVICE_META_DATA_KEY_AVAILABLE_ALGORITHMS; @@ -52,8 +50,6 @@ import java.io.PrintWriter; import java.util.ArrayList; import java.util.Arrays; import java.util.List; -import java.util.concurrent.CountDownLatch; -import java.util.concurrent.TimeUnit; /** * Strategy used to bridge the field classification algorithms provided by a service in an external diff --git a/services/autofill/java/com/android/server/autofill/Session.java b/services/autofill/java/com/android/server/autofill/Session.java index e6b2a3522fd1..58267f9564e9 100644 --- a/services/autofill/java/com/android/server/autofill/Session.java +++ b/services/autofill/java/com/android/server/autofill/Session.java @@ -98,7 +98,6 @@ import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.List; -import java.util.Map; import java.util.Objects; import java.util.concurrent.atomic.AtomicInteger; @@ -2482,13 +2481,14 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState } } pw.print(prefix); pw.print("mCurrentViewId: "); pw.println(mCurrentViewId); - pw.print(prefix); pw.print("mViewStates size: "); pw.println(mViewStates.size()); pw.print(prefix); pw.print("mDestroyed: "); pw.println(mDestroyed); pw.print(prefix); pw.print("mIsSaving: "); pw.println(mIsSaving); pw.print(prefix); pw.print("mPendingSaveUi: "); pw.println(mPendingSaveUi); - for (Map.Entry<AutofillId, ViewState> entry : mViewStates.entrySet()) { - pw.print(prefix); pw.print("State for id "); pw.println(entry.getKey()); - entry.getValue().dump(prefix2, pw); + final int numberViews = mViewStates.size(); + pw.print(prefix); pw.print("mViewStates size: "); pw.println(mViewStates.size()); + for (int i = 0; i < numberViews; i++) { + pw.print(prefix); pw.print("ViewState at #"); pw.println(i); + mViewStates.valueAt(i).dump(prefix2, pw); } pw.print(prefix); pw.print("mContexts: " ); @@ -2499,7 +2499,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState pw.print(prefix2); pw.print(context); if (sVerbose) { - pw.println(context.getStructure() + " (look at logcat)"); + pw.println("AssistStructure dumped at logcat)"); // TODO: add method on AssistStructure to dump on pw context.getStructure().dump(false); |