diff options
| author | 2018-05-15 21:13:16 -0400 | |
|---|---|---|
| committer | 2018-05-15 21:13:16 -0400 | |
| commit | 8938932a0af1e3a51864cb54c8b67a9424f55bcf (patch) | |
| tree | ecc7ef57d20f3f5a366d29ba24af0956a95c80ea | |
| parent | 3b592910c50856a3b28a07a735c31e19f44bc460 (diff) | |
Add some null checks to slices
It'll make developer debugging experience sooo much nicer.
Test: manual
Bug: 79773776
Change-Id: Ie0a826c5572752e2bb50db7669374a1698333770
| -rw-r--r-- | core/java/android/app/slice/Slice.java | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/core/java/android/app/slice/Slice.java b/core/java/android/app/slice/Slice.java index aadf904d6120..e54d3b64f780 100644 --- a/core/java/android/app/slice/Slice.java +++ b/core/java/android/app/slice/Slice.java @@ -28,6 +28,7 @@ import android.os.Parcel; import android.os.Parcelable; import com.android.internal.util.ArrayUtils; +import com.android.internal.util.Preconditions; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; @@ -427,6 +428,7 @@ public final class Slice implements Parcelable { * @see {@link SliceItem#getSubType()} */ public Builder addSubSlice(@NonNull Slice slice, @Nullable @SliceSubtype String subType) { + Preconditions.checkNotNull(slice); mItems.add(new SliceItem(slice, SliceItem.FORMAT_SLICE, subType, slice.getHints().toArray(new String[slice.getHints().size()]))); return this; @@ -439,6 +441,8 @@ public final class Slice implements Parcelable { */ public Slice.Builder addAction(@NonNull PendingIntent action, @NonNull Slice s, @Nullable @SliceSubtype String subType) { + Preconditions.checkNotNull(action); + Preconditions.checkNotNull(s); List<String> hints = s.getHints(); s.mSpec = null; mItems.add(new SliceItem(action, s, SliceItem.FORMAT_ACTION, subType, hints.toArray( @@ -464,6 +468,7 @@ public final class Slice implements Parcelable { */ public Builder addIcon(Icon icon, @Nullable @SliceSubtype String subType, @SliceHint List<String> hints) { + Preconditions.checkNotNull(icon); mItems.add(new SliceItem(icon, SliceItem.FORMAT_IMAGE, subType, hints)); return this; } @@ -476,6 +481,7 @@ public final class Slice implements Parcelable { public Slice.Builder addRemoteInput(RemoteInput remoteInput, @Nullable @SliceSubtype String subType, @SliceHint List<String> hints) { + Preconditions.checkNotNull(remoteInput); mItems.add(new SliceItem(remoteInput, SliceItem.FORMAT_REMOTE_INPUT, subType, hints)); return this; @@ -523,6 +529,7 @@ public final class Slice implements Parcelable { */ public Slice.Builder addBundle(Bundle bundle, @Nullable @SliceSubtype String subType, @SliceHint List<String> hints) { + Preconditions.checkNotNull(bundle); mItems.add(new SliceItem(bundle, SliceItem.FORMAT_BUNDLE, subType, hints)); return this; |