diff options
| author | 2023-07-31 13:53:52 +0000 | |
|---|---|---|
| committer | 2023-07-31 13:53:52 +0000 | |
| commit | 88c874299e6e303c814b246a802b0b39d9396a71 (patch) | |
| tree | 0dbf9e132397192e987cc2a2c80f50c7f50d09e1 | |
| parent | 40383d7977e6e611fa619af2add08bbef7eb7e53 (diff) | |
| parent | 45a6bab552795074a93e681018232d0d6abc0e1a (diff) | |
Merge "Make onVirtualDisplayRemoved callback idempotent." into udc-qpr-dev
2 files changed, 3 insertions, 9 deletions
diff --git a/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java b/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java index 254e6ce14630..cf7eb5122021 100644 --- a/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java +++ b/services/companion/java/com/android/server/companion/virtual/VirtualDeviceImpl.java @@ -983,8 +983,9 @@ final class VirtualDeviceImpl extends IVirtualDevice.Stub } if (virtualDisplayWrapper == null) { - throw new IllegalStateException( - "Virtual device doesn't have a virtual display with ID " + displayId); + Slog.w(TAG, "Virtual device " + mDeviceId + " doesn't have a virtual display with ID " + + displayId); + return; } final long ident = Binder.clearCallingIdentity(); diff --git a/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java b/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java index 8884dba217ed..2336374a3c5b 100644 --- a/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java +++ b/services/tests/servicestests/src/com/android/server/companion/virtual/VirtualDeviceManagerServiceTest.java @@ -789,13 +789,6 @@ public class VirtualDeviceManagerServiceTest { } @Test - public void onVirtualDisplayRemovedLocked_unknownDisplayId_throwsException() { - final int unknownDisplayId = 999; - assertThrows(IllegalStateException.class, - () -> mDeviceImpl.onVirtualDisplayRemoved(unknownDisplayId)); - } - - @Test public void onVirtualDisplayRemovedLocked_wakeLockIsReleased() throws RemoteException { addVirtualDisplay(mDeviceImpl, DISPLAY_ID_1); ArgumentCaptor<IBinder> wakeLockCaptor = ArgumentCaptor.forClass(IBinder.class); |