summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Rebecca Silberstein <silberst@google.com> 2016-10-04 13:53:33 -0700
committer Christopher Wiley <wiley@google.com> 2016-10-11 16:46:55 -0700
commit87e801411721932a4e74e84ec96d185a64875df5 (patch)
treeba4971d3b8cce26e925bd0bf695c4078c69d4df8
parentcbb03d1ad375fb5252a5da47f5438667134ab848 (diff)
Tethering: check if configManager is null
cherry-picked from b07f1409045091476e5296f9b0dd41c8712fe49a Before attempting to retrieve a carrier entitlement setting, first make sure we have a carrier config manager and if we do have a carrier config manager, the config it holds is not null. Bug: 31929638 Test: unittests coming in follow on CL Change-Id: Iee476c476cb3de109cdccbd955b7fb986dd4267b
-rw-r--r--services/core/java/com/android/server/connectivity/Tethering.java12
1 files changed, 7 insertions, 5 deletions
diff --git a/services/core/java/com/android/server/connectivity/Tethering.java b/services/core/java/com/android/server/connectivity/Tethering.java
index b3d5efa65267..1ca771f38940 100644
--- a/services/core/java/com/android/server/connectivity/Tethering.java
+++ b/services/core/java/com/android/server/connectivity/Tethering.java
@@ -404,11 +404,13 @@ public class Tethering extends BaseNetworkObserver implements IControlsTethering
// Check carrier config for entitlement checks
final CarrierConfigManager configManager = (CarrierConfigManager) mContext
.getSystemService(Context.CARRIER_CONFIG_SERVICE);
- boolean isEntitlementCheckRequired = configManager.getConfig().getBoolean(
- CarrierConfigManager.KEY_REQUIRE_ENTITLEMENT_CHECKS_BOOL);
-
- if (!isEntitlementCheckRequired) {
- return false;
+ if (configManager != null && configManager.getConfig() != null) {
+ // we do have a CarrierConfigManager and it has a config.
+ boolean isEntitlementCheckRequired = configManager.getConfig().getBoolean(
+ CarrierConfigManager.KEY_REQUIRE_ENTITLEMENT_CHECKS_BOOL);
+ if (!isEntitlementCheckRequired) {
+ return false;
+ }
}
return (provisionApp.length == 2);
}