diff options
| author | 2023-01-12 19:56:56 -0800 | |
|---|---|---|
| committer | 2023-01-13 18:58:30 +0000 | |
| commit | 86f01c4cd9177f285563db421c2cb052c51f7b9c (patch) | |
| tree | d4d0bf13ef36111b49001b292ea14a5db2dfdde1 | |
| parent | 027b3b377f39932a7a2b8507e37955b323545170 (diff) | |
Fix SmartspaceService callback comparison.
We should use binder references when comparing two IPC callbacks.
Test: Inject a test code into LocscreenSmartspaceController#reloadSmartspace() that register and unregister a test smartspace listener. Verify that the listeners is
get invoked without the fix and is not get invoked with the fix.
Change-Id: I3229c6496cde43ba1df65412857eb36b47b525c4
| -rw-r--r-- | core/java/android/service/smartspace/SmartspaceService.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/java/android/service/smartspace/SmartspaceService.java b/core/java/android/service/smartspace/SmartspaceService.java index 3a148dffe6d6..b13a069116af 100644 --- a/core/java/android/service/smartspace/SmartspaceService.java +++ b/core/java/android/service/smartspace/SmartspaceService.java @@ -302,7 +302,7 @@ public abstract class SmartspaceService extends Service { Slog.e(TAG, "Callback is null, likely the binder has died."); return false; } - return mCallback.equals(callback); + return mCallback.asBinder().equals(callback.asBinder()); } @Override |