summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Masaaki Iwaguchi <masaaki.x.iwaguchi@sonymobile.com> 2015-04-03 16:11:39 +0900
committer Ed Savage-Jones <edward.savage-jones@sonymobile.com> 2015-11-05 17:39:21 +0000
commit86d13f3daf6f5562bd83d086008d287c58d841c3 (patch)
tree90c2a6cae9e82d79e651cd66652809989c0b2310
parent82eeb2f20c934ddc97380032b3c8ecacc21d9a04 (diff)
Avoid NPE in printspooler when changing language
PrintActivity is recreated when the language setting is changed. As a result of the recreation mCurrentPrinter is null, which causes a NullPointerException when onActivityResult() is called. The issue is solved with a simple null check. Change-Id: Ic58f0ca01577d2ec02d494739f3bc2f06240dd44
-rw-r--r--packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java8
1 files changed, 5 insertions, 3 deletions
diff --git a/packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java b/packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java
index e8a5e43ce874..14bac4f03ccb 100644
--- a/packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java
+++ b/packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java
@@ -655,9 +655,11 @@ public class PrintActivity extends Activity implements RemotePrintDocument.Updat
}
}
- PrinterId printerId = mCurrentPrinter.getId();
- final int index = mDestinationSpinnerAdapter.getPrinterIndex(printerId);
- mDestinationSpinner.setSelection(index);
+ if (mCurrentPrinter != null) {
+ PrinterId printerId = mCurrentPrinter.getId();
+ final int index = mDestinationSpinnerAdapter.getPrinterIndex(printerId);
+ mDestinationSpinner.setSelection(index);
+ }
}
private void startAdvancedPrintOptionsActivity(PrinterInfo printer) {