diff options
| author | 2020-01-02 17:31:40 +0000 | |
|---|---|---|
| committer | 2020-01-07 11:34:16 +0000 | |
| commit | 82adfcbbba3811944bd86d00ccf7061e664dab97 (patch) | |
| tree | c430a69a35f247689ef7987fa8e01c1e29a5ea6c | |
| parent | f472e23be5bdb04d2e4c78b9decaca443190b362 (diff) | |
Replace com.android.internal.util.Preconditions.checkNotNull with
java.util.Objects.requireNonNull
Bug: 126528330
Test: Treehugger
Exempt-From-Owner-Approval: Global refactoring.
Change-Id: Ib5152a7dafed17b700ab6f1b24745864c552bcb4
14 files changed, 73 insertions, 63 deletions
diff --git a/services/core/java/com/android/server/pm/CrossProfileAppsServiceImpl.java b/services/core/java/com/android/server/pm/CrossProfileAppsServiceImpl.java index d2a6b42f3140..b25e1e2160c3 100644 --- a/services/core/java/com/android/server/pm/CrossProfileAppsServiceImpl.java +++ b/services/core/java/com/android/server/pm/CrossProfileAppsServiceImpl.java @@ -48,6 +48,7 @@ import com.android.server.wm.ActivityTaskManagerInternal; import java.util.ArrayList; import java.util.List; +import java.util.Objects; public class CrossProfileAppsServiceImpl extends ICrossProfileApps.Stub { private static final String TAG = "CrossProfileAppsService"; @@ -67,7 +68,7 @@ public class CrossProfileAppsServiceImpl extends ICrossProfileApps.Stub { @Override public List<UserHandle> getTargetUserProfiles(String callingPackage) { - Preconditions.checkNotNull(callingPackage); + Objects.requireNonNull(callingPackage); verifyCallingPackage(callingPackage); @@ -87,8 +88,8 @@ public class CrossProfileAppsServiceImpl extends ICrossProfileApps.Stub { ComponentName component, @UserIdInt int userId, boolean launchMainActivity) throws RemoteException { - Preconditions.checkNotNull(callingPackage); - Preconditions.checkNotNull(component); + Objects.requireNonNull(callingPackage); + Objects.requireNonNull(component); verifyCallingPackage(callingPackage); diff --git a/services/core/java/com/android/server/pm/KeySetManagerService.java b/services/core/java/com/android/server/pm/KeySetManagerService.java index 70c0f8d98447..f9cfee172f36 100644 --- a/services/core/java/com/android/server/pm/KeySetManagerService.java +++ b/services/core/java/com/android/server/pm/KeySetManagerService.java @@ -38,6 +38,7 @@ import java.io.IOException; import java.io.PrintWriter; import java.security.PublicKey; import java.util.Map; +import java.util.Objects; import java.util.Set; /* @@ -219,10 +220,10 @@ public class KeySetManagerService { } public void addScannedPackageLPw(AndroidPackage pkg) { - Preconditions.checkNotNull(pkg, "Attempted to add null pkg to ksms."); - Preconditions.checkNotNull(pkg.getPackageName(), "Attempted to add null pkg to ksms."); + Objects.requireNonNull(pkg, "Attempted to add null pkg to ksms."); + Objects.requireNonNull(pkg.getPackageName(), "Attempted to add null pkg to ksms."); PackageSetting ps = mPackages.get(pkg.getPackageName()); - Preconditions.checkNotNull(ps, "pkg: " + pkg.getPackageName() + Objects.requireNonNull(ps, "pkg: " + pkg.getPackageName() + "does not have a corresponding entry in mPackages."); addSigningKeySetToPackageLPw(ps, pkg.getSigningDetails().publicKeys); if (pkg.getKeySetMapping() != null) { @@ -504,7 +505,7 @@ public class KeySetManagerService { * Adds the given PublicKey to the system, deduping as it goes. */ private long addPublicKeyLPw(PublicKey key) { - Preconditions.checkNotNull(key, "Cannot add null public key!"); + Objects.requireNonNull(key, "Cannot add null public key!"); long id = getIdForPublicKeyLPr(key); if (id != PUBLIC_KEY_NOT_FOUND) { @@ -574,7 +575,7 @@ public class KeySetManagerService { /* remove refs from common keysets and public keys */ PackageSetting pkg = mPackages.get(packageName); - Preconditions.checkNotNull(pkg, "pkg name: " + packageName + Objects.requireNonNull(pkg, "pkg name: " + packageName + "does not have a corresponding entry in mPackages."); long signingKeySetId = pkg.keySetData.getProperSigningKeySet(); decrementKeySetLPw(signingKeySetId); diff --git a/services/core/java/com/android/server/pm/LauncherAppsService.java b/services/core/java/com/android/server/pm/LauncherAppsService.java index 673e265787f3..c4ef856e3ae7 100644 --- a/services/core/java/com/android/server/pm/LauncherAppsService.java +++ b/services/core/java/com/android/server/pm/LauncherAppsService.java @@ -78,6 +78,7 @@ import java.util.ArrayList; import java.util.Collections; import java.util.HashSet; import java.util.List; +import java.util.Objects; /** * Service that manages requests and callbacks for launchers that support @@ -136,15 +137,15 @@ public class LauncherAppsService extends SystemService { public LauncherAppsImpl(Context context) { mContext = context; mUm = (UserManager) mContext.getSystemService(Context.USER_SERVICE); - mUserManagerInternal = Preconditions.checkNotNull( + mUserManagerInternal = Objects.requireNonNull( LocalServices.getService(UserManagerInternal.class)); - mUsageStatsManagerInternal = Preconditions.checkNotNull( + mUsageStatsManagerInternal = Objects.requireNonNull( LocalServices.getService(UsageStatsManagerInternal.class)); - mActivityManagerInternal = Preconditions.checkNotNull( + mActivityManagerInternal = Objects.requireNonNull( LocalServices.getService(ActivityManagerInternal.class)); - mActivityTaskManagerInternal = Preconditions.checkNotNull( + mActivityTaskManagerInternal = Objects.requireNonNull( LocalServices.getService(ActivityTaskManagerInternal.class)); - mShortcutServiceInternal = Preconditions.checkNotNull( + mShortcutServiceInternal = Objects.requireNonNull( LocalServices.getService(ShortcutServiceInternal.class)); mShortcutServiceInternal.addListener(mPackageMonitor); mCallbackHandler = BackgroundThread.getHandler(); @@ -558,7 +559,7 @@ public class LauncherAppsService extends SystemService { if (!canAccessProfile(user.getIdentifier(), "Cannot check package")) { return null; } - Preconditions.checkNotNull(component); + Objects.requireNonNull(component); // All right, create the sender. Intent intent = new Intent(Intent.ACTION_CREATE_SHORTCUT).setComponent(component); diff --git a/services/core/java/com/android/server/pm/PackageInstallerSession.java b/services/core/java/com/android/server/pm/PackageInstallerSession.java index ac183dcf6b7a..c8689531ed98 100644 --- a/services/core/java/com/android/server/pm/PackageInstallerSession.java +++ b/services/core/java/com/android/server/pm/PackageInstallerSession.java @@ -140,6 +140,7 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.LinkedList; import java.util.List; +import java.util.Objects; import java.util.concurrent.atomic.AtomicInteger; import java.util.stream.Collectors; @@ -511,7 +512,7 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { this.userId = userId; mOriginalInstallerUid = installerUid; mInstallerUid = installerUid; - mInstallSource = Preconditions.checkNotNull(installSource); + mInstallSource = Objects.requireNonNull(installSource); this.params = params; this.createdMillis = createdMillis; this.updatedMillis = createdMillis; @@ -1143,7 +1144,7 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { * permissions. */ private boolean markAsCommitted(@NonNull IntentSender statusReceiver) { - Preconditions.checkNotNull(statusReceiver); + Objects.requireNonNull(statusReceiver); List<PackageInstallerSession> childSessions = getChildSessions(); @@ -1408,8 +1409,8 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { @Override public void transfer(String packageName, IntentSender statusReceiver) { - Preconditions.checkNotNull(statusReceiver); - Preconditions.checkNotNull(packageName); + Objects.requireNonNull(statusReceiver); + Objects.requireNonNull(packageName); try { assertCanBeTransferredAndReturnNewOwner(packageName); @@ -1607,9 +1608,9 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { localObserver = null; } else { if (!params.isMultiPackage) { - Preconditions.checkNotNull(mPackageName); - Preconditions.checkNotNull(mSigningDetails); - Preconditions.checkNotNull(mResolvedBaseFile); + Objects.requireNonNull(mPackageName); + Objects.requireNonNull(mSigningDetails); + Objects.requireNonNull(mResolvedBaseFile); if (needToAskForPermissionsLocked()) { // User needs to confirm installation; diff --git a/services/core/java/com/android/server/pm/PackageSettingBase.java b/services/core/java/com/android/server/pm/PackageSettingBase.java index 671450d71b4d..0c0b93b18f84 100644 --- a/services/core/java/com/android/server/pm/PackageSettingBase.java +++ b/services/core/java/com/android/server/pm/PackageSettingBase.java @@ -41,6 +41,7 @@ import com.android.internal.util.Preconditions; import java.io.File; import java.util.Arrays; import java.util.List; +import java.util.Objects; import java.util.Set; /** @@ -172,7 +173,7 @@ public abstract class PackageSettingBase extends SettingBase { } public void setInstallSource(InstallSource installSource) { - this.installSource = Preconditions.checkNotNull(installSource); + this.installSource = Objects.requireNonNull(installSource); } void removeInstallerPackage(String packageName) { diff --git a/services/core/java/com/android/server/pm/ShortcutBitmapSaver.java b/services/core/java/com/android/server/pm/ShortcutBitmapSaver.java index 815f8851e8e5..dc534a702946 100644 --- a/services/core/java/com/android/server/pm/ShortcutBitmapSaver.java +++ b/services/core/java/com/android/server/pm/ShortcutBitmapSaver.java @@ -38,6 +38,7 @@ import java.io.File; import java.io.IOException; import java.io.PrintWriter; import java.util.Deque; +import java.util.Objects; import java.util.concurrent.CountDownLatch; import java.util.concurrent.Executor; import java.util.concurrent.LinkedBlockingDeque; @@ -157,7 +158,7 @@ public class ShortcutBitmapSaver { public void saveBitmapLocked(ShortcutInfo shortcut, int maxDimension, CompressFormat format, int quality) { final Icon icon = shortcut.getIcon(); - Preconditions.checkNotNull(icon); + Objects.requireNonNull(icon); final Bitmap original = icon.getBitmap(); if (original == null) { diff --git a/services/core/java/com/android/server/pm/ShortcutPackage.java b/services/core/java/com/android/server/pm/ShortcutPackage.java index 06c71baade42..0274aee0a168 100644 --- a/services/core/java/com/android/server/pm/ShortcutPackage.java +++ b/services/core/java/com/android/server/pm/ShortcutPackage.java @@ -55,6 +55,7 @@ import java.util.ArrayList; import java.util.Collections; import java.util.Comparator; import java.util.List; +import java.util.Objects; import java.util.Set; import java.util.function.Predicate; @@ -454,7 +455,7 @@ class ShortcutPackage extends ShortcutPackageItem { public void updateInvisibleShortcutForPinRequestWith(@NonNull ShortcutInfo shortcut) { final ShortcutInfo source = mShortcuts.get(shortcut.getId()); - Preconditions.checkNotNull(source); + Objects.requireNonNull(source); mShortcutUser.mService.validateShortcutForPinRequest(shortcut); diff --git a/services/core/java/com/android/server/pm/ShortcutPackageItem.java b/services/core/java/com/android/server/pm/ShortcutPackageItem.java index 0629d9e45d64..6d9d69e00877 100644 --- a/services/core/java/com/android/server/pm/ShortcutPackageItem.java +++ b/services/core/java/com/android/server/pm/ShortcutPackageItem.java @@ -28,6 +28,7 @@ import org.xmlpull.v1.XmlPullParserException; import org.xmlpull.v1.XmlSerializer; import java.io.IOException; +import java.util.Objects; /** * All methods should be guarded by {@code #mShortcutUser.mService.mLock}. @@ -49,7 +50,7 @@ abstract class ShortcutPackageItem { mShortcutUser = shortcutUser; mPackageUserId = packageUserId; mPackageName = Preconditions.checkStringNotEmpty(packageName); - mPackageInfo = Preconditions.checkNotNull(packageInfo); + mPackageInfo = Objects.requireNonNull(packageInfo); } /** diff --git a/services/core/java/com/android/server/pm/ShortcutService.java b/services/core/java/com/android/server/pm/ShortcutService.java index f0a1c70057c4..261418ce7586 100644 --- a/services/core/java/com/android/server/pm/ShortcutService.java +++ b/services/core/java/com/android/server/pm/ShortcutService.java @@ -429,17 +429,17 @@ public class ShortcutService extends IShortcutService.Stub { @VisibleForTesting ShortcutService(Context context, Looper looper, boolean onlyForPackageManagerApis) { - mContext = Preconditions.checkNotNull(context); + mContext = Objects.requireNonNull(context); LocalServices.addService(ShortcutServiceInternal.class, new LocalService()); mHandler = new Handler(looper); mIPackageManager = AppGlobals.getPackageManager(); - mPackageManagerInternal = Preconditions.checkNotNull( + mPackageManagerInternal = Objects.requireNonNull( LocalServices.getService(PackageManagerInternal.class)); - mUserManagerInternal = Preconditions.checkNotNull( + mUserManagerInternal = Objects.requireNonNull( LocalServices.getService(UserManagerInternal.class)); - mUsageStatsManagerInternal = Preconditions.checkNotNull( + mUsageStatsManagerInternal = Objects.requireNonNull( LocalServices.getService(UsageStatsManagerInternal.class)); - mActivityManagerInternal = Preconditions.checkNotNull( + mActivityManagerInternal = Objects.requireNonNull( LocalServices.getService(ActivityManagerInternal.class)); mShortcutRequestPinProcessor = new ShortcutRequestPinProcessor(this, mLock); @@ -1680,7 +1680,7 @@ public class ShortcutService extends IShortcutService.Stub { "Re-publishing ShortcutInfo returned by server is not supported." + " Some information such as icon may lost from shortcut."); } - Preconditions.checkNotNull(shortcut, "Null shortcut detected"); + Objects.requireNonNull(shortcut, "Null shortcut detected"); if (shortcut.getActivity() != null) { Preconditions.checkState( shortcut.getPackage().equals(shortcut.getActivity().getPackageName()), @@ -1947,7 +1947,7 @@ public class ShortcutService extends IShortcutService.Stub { @Override public boolean requestPinShortcut(String packageName, ShortcutInfo shortcut, IntentSender resultIntent, int userId) { - Preconditions.checkNotNull(shortcut); + Objects.requireNonNull(shortcut); Preconditions.checkArgument(shortcut.isEnabled(), "Shortcut must be enabled"); return requestPinItem(packageName, userId, shortcut, null, null, resultIntent); } @@ -1955,7 +1955,7 @@ public class ShortcutService extends IShortcutService.Stub { @Override public Intent createShortcutResultIntent(String packageName, ShortcutInfo shortcut, int userId) throws RemoteException { - Preconditions.checkNotNull(shortcut); + Objects.requireNonNull(shortcut); Preconditions.checkArgument(shortcut.isEnabled(), "Shortcut must be enabled"); verifyCaller(packageName, userId); verifyShortcutInfoPackage(packageName, shortcut); @@ -2019,7 +2019,7 @@ public class ShortcutService extends IShortcutService.Stub { public void disableShortcuts(String packageName, List shortcutIds, CharSequence disabledMessage, int disabledMessageResId, @UserIdInt int userId) { verifyCaller(packageName, userId); - Preconditions.checkNotNull(shortcutIds, "shortcutIds must be provided"); + Objects.requireNonNull(shortcutIds, "shortcutIds must be provided"); synchronized (mLock) { throwIfUserLockedL(userId); @@ -2054,7 +2054,7 @@ public class ShortcutService extends IShortcutService.Stub { @Override public void enableShortcuts(String packageName, List shortcutIds, @UserIdInt int userId) { verifyCaller(packageName, userId); - Preconditions.checkNotNull(shortcutIds, "shortcutIds must be provided"); + Objects.requireNonNull(shortcutIds, "shortcutIds must be provided"); synchronized (mLock) { throwIfUserLockedL(userId); @@ -2081,7 +2081,7 @@ public class ShortcutService extends IShortcutService.Stub { public void removeDynamicShortcuts(String packageName, List shortcutIds, @UserIdInt int userId) { verifyCaller(packageName, userId); - Preconditions.checkNotNull(shortcutIds, "shortcutIds must be provided"); + Objects.requireNonNull(shortcutIds, "shortcutIds must be provided"); synchronized (mLock) { throwIfUserLockedL(userId); @@ -2256,7 +2256,7 @@ public class ShortcutService extends IShortcutService.Stub { public void reportShortcutUsed(String packageName, String shortcutId, int userId) { verifyCaller(packageName, userId); - Preconditions.checkNotNull(shortcutId); + Objects.requireNonNull(shortcutId); if (DEBUG) { Slog.d(TAG, String.format("reportShortcutUsed: Shortcut %s package %s used on user %d", @@ -2713,7 +2713,7 @@ public class ShortcutService extends IShortcutService.Stub { @NonNull List<String> shortcutIds, int userId) { // Calling permission must be checked by LauncherAppsImpl. Preconditions.checkStringNotEmpty(packageName, "packageName"); - Preconditions.checkNotNull(shortcutIds, "shortcutIds"); + Objects.requireNonNull(shortcutIds, "shortcutIds"); synchronized (mLock) { throwIfUserLockedL(userId); @@ -2766,16 +2766,16 @@ public class ShortcutService extends IShortcutService.Stub { @Override public void addListener(@NonNull ShortcutChangeListener listener) { synchronized (mLock) { - mListeners.add(Preconditions.checkNotNull(listener)); + mListeners.add(Objects.requireNonNull(listener)); } } @Override public int getShortcutIconResId(int launcherUserId, @NonNull String callingPackage, @NonNull String packageName, @NonNull String shortcutId, int userId) { - Preconditions.checkNotNull(callingPackage, "callingPackage"); - Preconditions.checkNotNull(packageName, "packageName"); - Preconditions.checkNotNull(shortcutId, "shortcutId"); + Objects.requireNonNull(callingPackage, "callingPackage"); + Objects.requireNonNull(packageName, "packageName"); + Objects.requireNonNull(shortcutId, "shortcutId"); synchronized (mLock) { throwIfUserLockedL(userId); @@ -2800,9 +2800,9 @@ public class ShortcutService extends IShortcutService.Stub { public ParcelFileDescriptor getShortcutIconFd(int launcherUserId, @NonNull String callingPackage, @NonNull String packageName, @NonNull String shortcutId, int userId) { - Preconditions.checkNotNull(callingPackage, "callingPackage"); - Preconditions.checkNotNull(packageName, "packageName"); - Preconditions.checkNotNull(shortcutId, "shortcutId"); + Objects.requireNonNull(callingPackage, "callingPackage"); + Objects.requireNonNull(packageName, "packageName"); + Objects.requireNonNull(shortcutId, "shortcutId"); synchronized (mLock) { throwIfUserLockedL(userId); @@ -2854,7 +2854,7 @@ public class ShortcutService extends IShortcutService.Stub { public boolean requestPinAppWidget(@NonNull String callingPackage, @NonNull AppWidgetProviderInfo appWidget, @Nullable Bundle extras, @Nullable IntentSender resultIntent, int userId) { - Preconditions.checkNotNull(appWidget); + Objects.requireNonNull(appWidget); return requestPinItem(callingPackage, userId, null, appWidget, extras, resultIntent); } @@ -2865,7 +2865,7 @@ public class ShortcutService extends IShortcutService.Stub { @Override public boolean isForegroundDefaultLauncher(@NonNull String callingPackage, int callingUid) { - Preconditions.checkNotNull(callingPackage); + Objects.requireNonNull(callingPackage); final int userId = UserHandle.getUserId(callingUid); final ComponentName defaultLauncher = getDefaultLauncher(userId); @@ -3411,7 +3411,7 @@ public class ShortcutService extends IShortcutService.Stub { List<ResolveInfo> queryActivities(@NonNull Intent baseIntent, @NonNull String packageName, @Nullable ComponentName activity, int userId) { - baseIntent.setPackage(Preconditions.checkNotNull(packageName)); + baseIntent.setPackage(Objects.requireNonNull(packageName)); if (activity != null) { baseIntent.setComponent(activity); } @@ -3529,7 +3529,7 @@ public class ShortcutService extends IShortcutService.Stub { @Nullable ComponentName injectGetPinConfirmationActivity(@NonNull String launcherPackageName, int launcherUserId, int requestType) { - Preconditions.checkNotNull(launcherPackageName); + Objects.requireNonNull(launcherPackageName); String action = requestType == LauncherApps.PinItemRequest.REQUEST_TYPE_SHORTCUT ? LauncherApps.ACTION_CONFIRM_PIN_SHORTCUT : LauncherApps.ACTION_CONFIRM_PIN_APPWIDGET; diff --git a/services/core/java/com/android/server/pm/ShortcutUser.java b/services/core/java/com/android/server/pm/ShortcutUser.java index 8c207a8e1a6f..eab3f4d8c44f 100644 --- a/services/core/java/com/android/server/pm/ShortcutUser.java +++ b/services/core/java/com/android/server/pm/ShortcutUser.java @@ -75,7 +75,7 @@ class ShortcutUser { private PackageWithUser(int userId, String packageName) { this.userId = userId; - this.packageName = Preconditions.checkNotNull(packageName); + this.packageName = Objects.requireNonNull(packageName); } public static PackageWithUser of(int userId, String packageName) { diff --git a/services/core/java/com/android/server/pm/UserManagerService.java b/services/core/java/com/android/server/pm/UserManagerService.java index 5854e321665b..1455d4ae1b10 100644 --- a/services/core/java/com/android/server/pm/UserManagerService.java +++ b/services/core/java/com/android/server/pm/UserManagerService.java @@ -434,7 +434,7 @@ public class UserManagerService extends IUserManager.Stub { private final IntentSender mTarget; public DisableQuietModeUserUnlockedCallback(IntentSender target) { - Preconditions.checkNotNull(target); + Objects.requireNonNull(target); mTarget = target; } @@ -884,7 +884,7 @@ public class UserManagerService extends IUserManager.Stub { @Override public boolean requestQuietModeEnabled(@NonNull String callingPackage, boolean enableQuietMode, @UserIdInt int userId, @Nullable IntentSender target) { - Preconditions.checkNotNull(callingPackage); + Objects.requireNonNull(callingPackage); if (enableQuietMode && target != null) { throw new IllegalArgumentException( diff --git a/services/core/java/com/android/server/pm/UserRestrictionsUtils.java b/services/core/java/com/android/server/pm/UserRestrictionsUtils.java index 90bd94781a1e..815f7b4357bf 100644 --- a/services/core/java/com/android/server/pm/UserRestrictionsUtils.java +++ b/services/core/java/com/android/server/pm/UserRestrictionsUtils.java @@ -51,6 +51,7 @@ import org.xmlpull.v1.XmlSerializer; import java.io.IOException; import java.io.PrintWriter; import java.util.List; +import java.util.Objects; import java.util.Set; /** @@ -357,7 +358,7 @@ public class UserRestrictionsUtils { } public static void merge(@NonNull Bundle dest, @Nullable Bundle in) { - Preconditions.checkNotNull(dest); + Objects.requireNonNull(dest); Preconditions.checkArgument(dest != in); if (in == null) { return; @@ -661,7 +662,7 @@ public class UserRestrictionsUtils { public static boolean isSettingRestrictedForUser(Context context, @NonNull String setting, int userId, String value, int callingUid) { - Preconditions.checkNotNull(setting); + Objects.requireNonNull(setting); final UserManager mUserManager = context.getSystemService(UserManager.class); String restriction; boolean checkAllUser = false; diff --git a/services/core/java/com/android/server/pm/dex/ArtManagerService.java b/services/core/java/com/android/server/pm/dex/ArtManagerService.java index 486cfeff0739..0caab6dddfe3 100644 --- a/services/core/java/com/android/server/pm/dex/ArtManagerService.java +++ b/services/core/java/com/android/server/pm/dex/ArtManagerService.java @@ -62,6 +62,7 @@ import libcore.io.IoUtils; import java.io.File; import java.io.FileNotFoundException; +import java.util.Objects; /** * A system service that provides access to runtime and compiler artifacts. @@ -180,7 +181,7 @@ public class ArtManagerService extends android.content.pm.dex.IArtManager.Stub { } // Sanity checks on the arguments. - Preconditions.checkNotNull(callback); + Objects.requireNonNull(callback); boolean bootImageProfile = profileType == ArtManager.PROFILE_BOOT_IMAGE; if (!bootImageProfile) { diff --git a/services/core/java/com/android/server/pm/permission/PermissionManagerService.java b/services/core/java/com/android/server/pm/permission/PermissionManagerService.java index 9cd6f16ca118..d921f313eb48 100644 --- a/services/core/java/com/android/server/pm/permission/PermissionManagerService.java +++ b/services/core/java/com/android/server/pm/permission/PermissionManagerService.java @@ -796,7 +796,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { @Override public int checkPermission(String permName, String pkgName, int userId) { - // Not using Preconditions.checkNotNull() here for compatibility reasons. + // Not using Objects.requireNonNull() here for compatibility reasons. if (permName == null || pkgName == null) { return PackageManager.PERMISSION_DENIED; } @@ -872,7 +872,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { @Override public int checkUidPermission(String permName, int uid) { - // Not using Preconditions.checkNotNull() here for compatibility reasons. + // Not using Objects.requireNonNull() here for compatibility reasons. if (permName == null) { return PackageManager.PERMISSION_DENIED; } @@ -955,7 +955,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { @Override @Nullable public List<String> getWhitelistedRestrictedPermissions(@NonNull String packageName, @PermissionWhitelistFlags int flags, @UserIdInt int userId) { - Preconditions.checkNotNull(packageName); + Objects.requireNonNull(packageName); Preconditions.checkFlagsArgument(flags, PackageManager.FLAG_PERMISSION_WHITELIST_UPGRADE | PackageManager.FLAG_PERMISSION_WHITELIST_SYSTEM @@ -1043,7 +1043,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { @NonNull String permName, @PermissionWhitelistFlags int flags, @UserIdInt int userId) { // Other argument checks are done in get/setWhitelistedRestrictedPermissions - Preconditions.checkNotNull(permName); + Objects.requireNonNull(permName); if (!checkExistsAndEnforceCannotModifyImmutablyRestrictedPermission(permName)) { return false; @@ -1086,7 +1086,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { @NonNull String permName, @PermissionWhitelistFlags int flags, @UserIdInt int userId) { // Other argument checks are done in get/setWhitelistedRestrictedPermissions - Preconditions.checkNotNull(permName); + Objects.requireNonNull(permName); if (!checkExistsAndEnforceCannotModifyImmutablyRestrictedPermission(permName)) { return false; @@ -1104,7 +1104,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { private boolean setWhitelistedRestrictedPermissionsInternal(@NonNull String packageName, @Nullable List<String> permissions, @PermissionWhitelistFlags int flags, @UserIdInt int userId) { - Preconditions.checkNotNull(packageName); + Objects.requireNonNull(packageName); Preconditions.checkFlagsArgument(flags, PackageManager.FLAG_PERMISSION_WHITELIST_UPGRADE | PackageManager.FLAG_PERMISSION_WHITELIST_SYSTEM @@ -3028,7 +3028,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { mContext.enforceCallingPermission(Manifest.permission.MANAGE_ONE_TIME_PERMISSION_SESSIONS, "Must hold " + Manifest.permission.MANAGE_ONE_TIME_PERMISSION_SESSIONS + " to register permissions as one time."); - packageName = Preconditions.checkNotNull(packageName); + Objects.requireNonNull(packageName); long token = Binder.clearCallingIdentity(); try { @@ -3044,7 +3044,7 @@ public class PermissionManagerService extends IPermissionManager.Stub { mContext.enforceCallingPermission(Manifest.permission.MANAGE_ONE_TIME_PERMISSION_SESSIONS, "Must hold " + Manifest.permission.MANAGE_ONE_TIME_PERMISSION_SESSIONS + " to remove permissions as one time."); - Preconditions.checkNotNull(packageName); + Objects.requireNonNull(packageName); long token = Binder.clearCallingIdentity(); try { |