diff options
| author | 2022-11-07 21:35:05 +0000 | |
|---|---|---|
| committer | 2022-11-07 16:41:22 -0600 | |
| commit | 7c698c7a409f098364f9de9c54781795848e7e64 (patch) | |
| tree | 76a5d28c44317a9de3751fb9c609a1e91d344233 | |
| parent | 983769ffef35d1fbc2b0f02bf47e9a26a33b8c2d (diff) | |
Revert "Revert "Add unaudited exported flag to exposed runtime receivers""
This reverts commit 9041b19e137a60ee3f13bb40022037dbb672bd17.
Reason for revert: Failing tests have been resolved, reverting to
restore the other flagged receivers from the original CL.
This commit also marks the BubbleController's receiver as exported
since the ACTION_CLOSE_SYSTEM_DIALOGS broadcast can only be sent
by tests on T+ devices.
Bug: 234659204
Test: atest SystemUITests:com.android.systemui.statusbar.policy.SafetyControllerTest
Test: atest SystemUITests:com.android.systemui.wmshell.BubblesTest
Change-Id: Id6370750cab69d49e001f783051e4248201639e4
4 files changed, 8 insertions, 7 deletions
diff --git a/core/tests/coretests/src/android/app/activity/LocalReceiver.java b/core/tests/coretests/src/android/app/activity/LocalReceiver.java index 7f813390552c..5ac84f809564 100644 --- a/core/tests/coretests/src/android/app/activity/LocalReceiver.java +++ b/core/tests/coretests/src/android/app/activity/LocalReceiver.java @@ -36,7 +36,8 @@ public class LocalReceiver extends BroadcastReceiver { if (BroadcastTest.BROADCAST_FAIL_REGISTER.equals(intent.getAction())) { resultString = "Successfully registered, but expected it to fail"; try { - context.registerReceiver(this, new IntentFilter("foo.bar")); + context.registerReceiver(this, new IntentFilter("foo.bar"), + Context.RECEIVER_EXPORTED_UNAUDITED); context.unregisterReceiver(this); } catch (ReceiverCallNotAllowedException e) { //resultString = "This is the correct behavior but not yet implemented"; diff --git a/core/tests/coretests/src/android/app/activity/ServiceTest.java b/core/tests/coretests/src/android/app/activity/ServiceTest.java index c89f37db7fed..3f3d6a3bff34 100644 --- a/core/tests/coretests/src/android/app/activity/ServiceTest.java +++ b/core/tests/coretests/src/android/app/activity/ServiceTest.java @@ -172,7 +172,7 @@ public class ServiceTest extends TestCase { pidResult.complete(intent.getIntExtra(EXTRA_PID, NOT_STARTED)); mContext.unregisterReceiver(this); } - }, new IntentFilter(ACTION_SERVICE_STARTED)); + }, new IntentFilter(ACTION_SERVICE_STARTED), Context.RECEIVER_EXPORTED_UNAUDITED); serviceTrigger.run(); try { diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleController.java b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleController.java index a400555d31a8..1fd91debe3f6 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleController.java +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleController.java @@ -709,7 +709,7 @@ public class BubbleController implements ConfigurationChangeListener { IntentFilter filter = new IntentFilter(); filter.addAction(Intent.ACTION_CLOSE_SYSTEM_DIALOGS); filter.addAction(Intent.ACTION_SCREEN_OFF); - mContext.registerReceiver(mBroadcastReceiver, filter); + mContext.registerReceiver(mBroadcastReceiver, filter, Context.RECEIVER_EXPORTED); } private final BroadcastReceiver mBroadcastReceiver = new BroadcastReceiver() { diff --git a/packages/SystemUI/tests/src/com/android/systemui/wmshell/BubblesTest.java b/packages/SystemUI/tests/src/com/android/systemui/wmshell/BubblesTest.java index bee882d43849..bb15c956a1ee 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/wmshell/BubblesTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/wmshell/BubblesTest.java @@ -1329,7 +1329,7 @@ public class BubblesTest extends SysuiTestCase { spyOn(mContext); mBubbleController.updateBubble(mBubbleEntry); verify(mContext).registerReceiver(mBroadcastReceiverArgumentCaptor.capture(), - mFilterArgumentCaptor.capture()); + mFilterArgumentCaptor.capture(), eq(Context.RECEIVER_EXPORTED)); assertThat(mFilterArgumentCaptor.getValue().getAction(0)).isEqualTo( Intent.ACTION_CLOSE_SYSTEM_DIALOGS); assertThat(mFilterArgumentCaptor.getValue().getAction(1)).isEqualTo( @@ -1349,7 +1349,7 @@ public class BubblesTest extends SysuiTestCase { mBubbleController.updateBubble(mBubbleEntry); mBubbleData.setExpanded(true); verify(mContext).registerReceiver(mBroadcastReceiverArgumentCaptor.capture(), - mFilterArgumentCaptor.capture()); + mFilterArgumentCaptor.capture(), eq(Context.RECEIVER_EXPORTED)); Intent i = new Intent(Intent.ACTION_CLOSE_SYSTEM_DIALOGS); mBroadcastReceiverArgumentCaptor.getValue().onReceive(mContext, i); @@ -1363,7 +1363,7 @@ public class BubblesTest extends SysuiTestCase { mBubbleData.setExpanded(true); verify(mContext).registerReceiver(mBroadcastReceiverArgumentCaptor.capture(), - mFilterArgumentCaptor.capture()); + mFilterArgumentCaptor.capture(), eq(Context.RECEIVER_EXPORTED)); Intent i = new Intent(Intent.ACTION_CLOSE_SYSTEM_DIALOGS); i.putExtra("reason", "gestureNav"); mBroadcastReceiverArgumentCaptor.getValue().onReceive(mContext, i); @@ -1377,7 +1377,7 @@ public class BubblesTest extends SysuiTestCase { mBubbleData.setExpanded(true); verify(mContext).registerReceiver(mBroadcastReceiverArgumentCaptor.capture(), - mFilterArgumentCaptor.capture()); + mFilterArgumentCaptor.capture(), eq(Context.RECEIVER_EXPORTED)); Intent i = new Intent(Intent.ACTION_SCREEN_OFF); mBroadcastReceiverArgumentCaptor.getValue().onReceive(mContext, i); |