summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> 2024-06-26 21:59:25 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2024-06-26 21:59:25 +0000
commit7c4d88f724e33f29c2ae78a388a535b46e1be5a5 (patch)
tree2ef1ccab0fbb3b964c178946e95f5bfe30cc1249
parent123a3c5d0f439bf1e664444ead007494c0662e53 (diff)
parent182f0eba6b6ab6cb8a7f5be1321bcdb1497d90b6 (diff)
Merge "Update a stale comment in IMMS constructor" into main
-rw-r--r--services/core/java/com/android/server/inputmethod/InputMethodManagerService.java8
1 files changed, 7 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
index 2d7761026239..9de14f1fb9ec 100644
--- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
@@ -1274,7 +1274,13 @@ public final class InputMethodManagerService implements IInputMethodManagerImpl.
mShowOngoingImeSwitcherForPhones = false;
- // InputMethodSettingsRepository should be initialized before buildInputMethodListLocked
+ // Executing InputMethodSettingsRepository.initialize() does not mean that it
+ // immediately becomes ready to return the up-to-date InputMethodSettings for each
+ // running user, because we want to return from the constructor as early as possible so
+ // as not to delay the system boot process.
+ // Search for InputMethodSettingsRepository.put() to find where and when it's actually
+ // being updated. In general IMMS should refrain from exposing the existence of IMEs
+ // until systemReady().
InputMethodSettingsRepository.initialize(mHandler, mContext);
AdditionalSubtypeMapRepository.initialize(mHandler, mContext);