diff options
| author | 2022-10-26 17:00:16 +0100 | |
|---|---|---|
| committer | 2022-10-27 14:29:15 +0100 | |
| commit | 7b5962991c434b26b10cd537ee32705743fb1345 (patch) | |
| tree | 59000d325cfef57031b025795c5612d2a7ae8b46 | |
| parent | f382a4ce223464bdd3cd7265c5c010b8b3e9ff13 (diff) | |
Fixing QS not visible when opening split shade with adb command
The command stopped working because we stopped relying on implicitly expanded state and now we want to explicitly change state to qsExpanded when shade is expanded. That will be done automatically if LockscreenShadeTransitionController animates QS.
Fixes: 255445410
Test: run "adb shell cmd accessibility call-system-action 5" in split lockscreen and see QS appearing
Change-Id: I9b80cfac476e0089300639e03efcc669ca99a22a
2 files changed, 2 insertions, 2 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java b/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java index 9ac328868960..1e2d5602bc34 100644 --- a/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java +++ b/packages/SystemUI/src/com/android/systemui/shade/NotificationPanelViewController.java @@ -2020,7 +2020,7 @@ public final class NotificationPanelViewController {              // case but currently motion in portrait looks worse than when using flingSettings.              // TODO: make below function transitioning smoothly also in portrait with null target              mLockscreenShadeTransitionController.goToLockedShade( -                    /* expandedView= */null, /* needsQSAnimation= */false); +                    /* expandedView= */null, /* needsQSAnimation= */true);          } else if (isFullyCollapsed()) {              expand(true /* animate */);          } else { diff --git a/packages/SystemUI/tests/src/com/android/systemui/shade/NotificationPanelViewControllerTest.java b/packages/SystemUI/tests/src/com/android/systemui/shade/NotificationPanelViewControllerTest.java index 9713b71db575..b7f8f8d166a3 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/shade/NotificationPanelViewControllerTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/shade/NotificationPanelViewControllerTest.java @@ -1285,7 +1285,7 @@ public class NotificationPanelViewControllerTest extends SysuiTestCase {          mNotificationPanelViewController.expandWithQs();          verify(mLockscreenShadeTransitionController).goToLockedShade( -                /* expandedView= */null, /* needsQSAnimation= */false); +                /* expandedView= */null, /* needsQSAnimation= */true);      }      @Test  |