summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Ilya Matyukhin <ilyamaty@google.com> 2022-04-07 00:55:08 +0000
committer Ilya Matyukhin <ilyamaty@google.com> 2022-04-07 01:03:59 +0000
commit78ac57b034f8feb003e19d5d4ac8cc184b440a3c (patch)
treed9863d34394ff9004162e54da9fab77f32332ed3
parentb497365a27328a77ae0eb85218e23ab49cab5410 (diff)
Tighten the scope of ACTION_UDFPS_ILLUMINATE
This metric is not supposed to reflect the latency outside of the illumination path, such as the time it takes the user to move their finger to the trigger point on the sensor. Bug: 221125251 Test: N/A Change-Id: I47ea062a0527aed774ad5bd5e778a1def7f94601
-rw-r--r--packages/SystemUI/src/com/android/systemui/biometrics/UdfpsController.java4
1 files changed, 1 insertions, 3 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsController.java b/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsController.java
index 63b2b201c498..2ac240885faa 100644
--- a/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsController.java
+++ b/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsController.java
@@ -376,7 +376,6 @@ public class UdfpsController implements DozeReceiver {
boolean withinSensorArea =
isWithinSensorArea(udfpsView, event.getX(), event.getY(), fromUdfpsView);
if (withinSensorArea) {
- mLatencyTracker.onActionStart(LatencyTracker.ACTION_UDFPS_ILLUMINATE);
Trace.beginAsyncSection("UdfpsController.e2e.onPointerDown", 0);
Log.v(TAG, "onTouch | action down");
// The pointer that causes ACTION_DOWN is always at index 0.
@@ -792,6 +791,7 @@ public class UdfpsController implements DozeReceiver {
+ " current: " + mOverlay.getRequestId());
return;
}
+ mLatencyTracker.onActionStart(LatencyTracker.ACTION_UDFPS_ILLUMINATE);
if (!mOnFingerDown) {
playStartHaptic();
@@ -806,11 +806,9 @@ public class UdfpsController implements DozeReceiver {
final UdfpsView view = mOverlay.getOverlayView();
if (view != null) {
- Trace.beginAsyncSection("UdfpsController.e2e.startIllumination", 0);
view.startIllumination(() -> {
mFingerprintManager.onUiReady(requestId, mSensorProps.sensorId);
mLatencyTracker.onActionEnd(LatencyTracker.ACTION_UDFPS_ILLUMINATE);
- Trace.endAsyncSection("UdfpsController.e2e.startIllumination", 0);
});
}