diff options
| author | 2022-02-18 16:23:51 +0000 | |
|---|---|---|
| committer | 2022-02-18 16:33:32 +0000 | |
| commit | 73f1063c39edfe12ba96b888b98acc6e718dd8f8 (patch) | |
| tree | 8eafd9c0c085308387e7cd91bb12ceaf9340d9bc | |
| parent | dad3c928d8d393a6f01508c9f452f0537095328b (diff) | |
base: remove onBind and onMessage from TraceReport API surface
Bug: 217554856
Change-Id: I9e60d20d5a7f159ad80a6ca256dd59c644aa4bc1
| -rw-r--r-- | core/api/system-current.txt | 2 | ||||
| -rw-r--r-- | core/java/android/service/tracing/TraceReportService.java | 12 |
2 files changed, 4 insertions, 10 deletions
diff --git a/core/api/system-current.txt b/core/api/system-current.txt index 2c7f456c5e76..5c6076be4dc9 100644 --- a/core/api/system-current.txt +++ b/core/api/system-current.txt @@ -10131,8 +10131,6 @@ package android.service.tracing { public class TraceReportService extends android.app.Service { ctor public TraceReportService(); - method @Nullable public android.os.IBinder onBind(@NonNull android.content.Intent); - method public boolean onMessage(@NonNull android.os.Message); method public void onReportTrace(@NonNull android.service.tracing.TraceReportService.TraceParams); } diff --git a/core/java/android/service/tracing/TraceReportService.java b/core/java/android/service/tracing/TraceReportService.java index 3d16a3d41ea3..6fdc8e8eb961 100644 --- a/core/java/android/service/tracing/TraceReportService.java +++ b/core/java/android/service/tracing/TraceReportService.java @@ -112,7 +112,6 @@ public class TraceReportService extends Service { } } - // Methods to override. /** * Called when a trace is reported and sent to this class. * @@ -123,15 +122,10 @@ public class TraceReportService extends Service { public void onReportTrace(@NonNull TraceParams args) { } - // Optional methods to override. - // Realistically, these methods are internal implementation details but since this class is - // a SystemApi, it's better to err on the side of flexibility just in-case we need to override - // these methods down the line. - /** * Handles binder calls from system_server. */ - public boolean onMessage(@NonNull Message msg) { + private boolean onMessage(@NonNull Message msg) { if (msg.what == MSG_REPORT_TRACE) { if (!(msg.obj instanceof TraceReportParams)) { Log.e(TAG, "Received invalid type for report trace message."); @@ -153,10 +147,12 @@ public class TraceReportService extends Service { /** * Returns an IBinder for handling binder calls from system_server. + * + * @hide */ @Nullable @Override - public IBinder onBind(@NonNull Intent intent) { + public final IBinder onBind(@NonNull Intent intent) { if (mMessenger == null) { mMessenger = new Messenger(new Handler(Looper.getMainLooper(), this::onMessage)); } |