summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Matt Buckley <mattbuckley@google.com> 2023-09-26 19:30:25 +0000
committer Matt Buckley <mattbuckley@google.com> 2023-09-27 19:07:28 +0000
commit73b143c6cd334c5369fa801b54952aa1ebae26c6 (patch)
treeec100f5eeb81e4a883b1d05ca0cdcf80ab0fd6fa
parent56916c44d70687e8549dda3eb73a8e385008e5be (diff)
Send cached target duration when creating sessions
This fixes an issue where the default target duration was being sent when re-creating sessions, after the true target duration was already known. This caused the wrong value in PowerHAL, and no corrective update was sent because the cached value never changed. Bug: 301806277 Test: hwuitest Change-Id: I80d90e855fce92264d8341aad78b19dc547b65f4 Merged-In: I80d90e855fce92264d8341aad78b19dc547b65f4
-rw-r--r--libs/hwui/renderthread/HintSessionWrapper.cpp7
-rw-r--r--libs/hwui/renderthread/HintSessionWrapper.h1
2 files changed, 5 insertions, 3 deletions
diff --git a/libs/hwui/renderthread/HintSessionWrapper.cpp b/libs/hwui/renderthread/HintSessionWrapper.cpp
index d1ebe6d9f576..565da52de940 100644
--- a/libs/hwui/renderthread/HintSessionWrapper.cpp
+++ b/libs/hwui/renderthread/HintSessionWrapper.cpp
@@ -72,6 +72,7 @@ void HintSessionWrapper::destroy() {
mSessionValid = true;
mHintSession = nullptr;
}
+ mResetsSinceLastReport = 0;
}
bool HintSessionWrapper::init() {
@@ -111,10 +112,10 @@ bool HintSessionWrapper::init() {
// Use a placeholder target value to initialize,
// this will always be replaced elsewhere before it gets used
- int64_t defaultTargetDurationNanos = 16666667;
+ int64_t targetDurationNanos =
+ mLastTargetWorkDuration == 0 ? kDefaultTargetDuration : mLastTargetWorkDuration;
mHintSessionFuture = CommonPool::async([=, this, tids = std::move(tids)] {
- return mBinding->createSession(manager, tids.data(), tids.size(),
- defaultTargetDurationNanos);
+ return mBinding->createSession(manager, tids.data(), tids.size(), targetDurationNanos);
});
return false;
}
diff --git a/libs/hwui/renderthread/HintSessionWrapper.h b/libs/hwui/renderthread/HintSessionWrapper.h
index 36e91ea33c75..41891cd80a42 100644
--- a/libs/hwui/renderthread/HintSessionWrapper.h
+++ b/libs/hwui/renderthread/HintSessionWrapper.h
@@ -65,6 +65,7 @@ private:
static constexpr nsecs_t kResetHintTimeout = 100_ms;
static constexpr int64_t kSanityCheckLowerBound = 100_us;
static constexpr int64_t kSanityCheckUpperBound = 10_s;
+ static constexpr int64_t kDefaultTargetDuration = 16666667;
// Allows easier stub when testing
class HintSessionBinding {