diff options
| author | 2024-03-19 17:28:50 +0000 | |
|---|---|---|
| committer | 2024-03-26 23:35:33 +0000 | |
| commit | 73a5d1b258faf786b743ff16ac49bd4202b0e3c9 (patch) | |
| tree | d4111a0104b30d5ae8946ae8e394d5f77af6e004 | |
| parent | 5843daa8af0a05344e8594be071defbe7f1ab44c (diff) | |
Sony DualShock 4: disable drumroll suppression
After further investigation, it seems that while disabling drumroll
detection by speed change fixed pointer movement issues, the bad pointer
speed values were also breaking tap-to-click. I can't produce drumroll
issues on this touchpad anyway, so let's just disable drumroll
suppression completely.
Bug: 330300506
Bug: 329585708
Test: connect DualShock 4 by Bluetooth, check tapping to click works,
drum your fingers on the pad and check the cursor doesn't jump
around
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a4b33afae1a29f5d8f6ec7b579bad151348274bc)
Merged-In: Ie645ac5b4c6fc5c2ea4fc3611d815baa21ecd5c9
Change-Id: Ie645ac5b4c6fc5c2ea4fc3611d815baa21ecd5c9
| -rw-r--r-- | data/keyboards/Vendor_054c_Product_05c4.idc | 15 | ||||
| -rw-r--r-- | data/keyboards/Vendor_054c_Product_09cc.idc | 15 |
2 files changed, 16 insertions, 14 deletions
diff --git a/data/keyboards/Vendor_054c_Product_05c4.idc b/data/keyboards/Vendor_054c_Product_05c4.idc index 9576e8d042ba..2da622745baf 100644 --- a/data/keyboards/Vendor_054c_Product_05c4.idc +++ b/data/keyboards/Vendor_054c_Product_05c4.idc @@ -45,14 +45,15 @@ sensor.gyroscope.power = 0.8 # This uneven timing causes the apparent speed of a finger (calculated using # time deltas between received reports) to vary dramatically even if it's # actually moving smoothly across the touchpad, triggering the touchpad stack's -# drumroll detection logic, which causes the finger's single smooth movement to -# be treated as many small movements of consecutive touches, which are then -# inhibited by the click wiggle filter. +# drumroll detection logic. For moving fingers, the drumroll detection logic +# splits the finger's single movement into many small movements of consecutive +# touches, which are then inhibited by the click wiggle filter. For tapping +# fingers, it prevents tapping to click because it thinks the finger's moving +# too fast. # -# Since this touchpad does not seem vulnerable to click wiggle, we can safely -# disable drumroll detection due to speed changes (by setting the speed change -# threshold very high, since there's no boolean control property). -gestureProp.Drumroll_Max_Speed_Change_Factor = 1000000000 +# Since this touchpad doesn't seem to have to drumroll issues, we can safely +# disable drumroll detection. +gestureProp.Drumroll_Suppression_Enable = 0 # Because of the way this touchpad is positioned, touches around the edges are # no more likely to be palms than ones in the middle, so remove the edge zones diff --git a/data/keyboards/Vendor_054c_Product_09cc.idc b/data/keyboards/Vendor_054c_Product_09cc.idc index 9576e8d042ba..2a1a4fc62b24 100644 --- a/data/keyboards/Vendor_054c_Product_09cc.idc +++ b/data/keyboards/Vendor_054c_Product_09cc.idc @@ -45,14 +45,15 @@ sensor.gyroscope.power = 0.8 # This uneven timing causes the apparent speed of a finger (calculated using # time deltas between received reports) to vary dramatically even if it's # actually moving smoothly across the touchpad, triggering the touchpad stack's -# drumroll detection logic, which causes the finger's single smooth movement to -# be treated as many small movements of consecutive touches, which are then -# inhibited by the click wiggle filter. +# drumroll detection logic. For moving fingers, the drumroll detection logic +# splits the finger's single movement into many small movements of consecutive +# touches, which are then inhibited by the click wiggle filter. For tapping +# fingers, it prevents tapping to click because it thinks the finger's moving +# too fast. # -# Since this touchpad does not seem vulnerable to click wiggle, we can safely -# disable drumroll detection due to speed changes (by setting the speed change -# threshold very high, since there's no boolean control property). -gestureProp.Drumroll_Max_Speed_Change_Factor = 1000000000 +# Since this touchpad doesn't seem to have drumroll issues, we can safely +# disable drumroll detection. +gestureProp.Drumroll_Suppression_Enable = 0 # Because of the way this touchpad is positioned, touches around the edges are # no more likely to be palms than ones in the middle, so remove the edge zones |