diff options
| author | 2024-11-26 13:14:48 -0800 | |
|---|---|---|
| committer | 2024-11-26 13:54:08 -0800 | |
| commit | 71c02c1c051fa46ac217ce38879b4ac0db326956 (patch) | |
| tree | 59ed8b4c814acf37f4bdcd2638589d413c4393a7 | |
| parent | ff3f7398e8e8b4e48df0a35b2fde01f0b24634f7 (diff) | |
Remove complication duplication
The dream complication component and module have the same naming as the
base complication component and module. This makes it much more
difficult to visualize the SysUI dagger graph due to the duplicated
display names. Renaming the dream classes to a more descriptive name
fixes this issue.
Bug: 374154382
Test: build
Flag: NONE refactor
Change-Id: Iac2d7ad1c1369da5fb22cc7540a5cdedea6a832e
| -rw-r--r-- | packages/SystemUI/multivalentTests/src/com/android/systemui/dreams/DreamOverlayServiceTest.kt | 13 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/dreams/DreamOverlayService.java | 13 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/dreams/complication/HideComplicationTouchHandler.java | 4 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/DreamComplicationComponent.kt (renamed from packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/ComplicationComponent.kt) | 10 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/DreamComplicationModule.kt (renamed from packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/ComplicationModule.kt) | 4 | ||||
| -rw-r--r-- | packages/SystemUI/src/com/android/systemui/dreams/dagger/DreamModule.java | 4 |
6 files changed, 22 insertions, 26 deletions
diff --git a/packages/SystemUI/multivalentTests/src/com/android/systemui/dreams/DreamOverlayServiceTest.kt b/packages/SystemUI/multivalentTests/src/com/android/systemui/dreams/DreamOverlayServiceTest.kt index a8048793be06..f924ccb42cb0 100644 --- a/packages/SystemUI/multivalentTests/src/com/android/systemui/dreams/DreamOverlayServiceTest.kt +++ b/packages/SystemUI/multivalentTests/src/com/android/systemui/dreams/DreamOverlayServiceTest.kt @@ -62,6 +62,7 @@ import com.android.systemui.complication.ComplicationHostViewController import com.android.systemui.complication.ComplicationLayoutEngine import com.android.systemui.complication.dagger.ComplicationComponent import com.android.systemui.dreams.complication.HideComplicationTouchHandler +import com.android.systemui.dreams.complication.dagger.DreamComplicationComponent import com.android.systemui.dreams.dagger.DreamOverlayComponent import com.android.systemui.dreams.touch.CommunalTouchHandler import com.android.systemui.flags.andSceneContainer @@ -119,8 +120,7 @@ class DreamOverlayServiceTest(flags: FlagsParameterization?) : SysuiTestCase() { private val mComplicationComponentFactory = mock<ComplicationComponent.Factory>() private val mComplicationHostViewController = mock<ComplicationHostViewController>() private val mComplicationVisibilityController = mock<ComplicationLayoutEngine>() - private val mDreamComplicationComponentFactory = - mock<com.android.systemui.dreams.complication.dagger.ComplicationComponent.Factory>() + private val mDreamComplicationComponentFactory = mock<DreamComplicationComponent.Factory>() private val mHideComplicationTouchHandler = mock<HideComplicationTouchHandler>() private val mDreamOverlayComponentFactory = mock<DreamOverlayComponent.Factory>() private val mCommunalTouchHandler = mock<CommunalTouchHandler>() @@ -160,8 +160,7 @@ class DreamOverlayServiceTest(flags: FlagsParameterization?) : SysuiTestCase() { private lateinit var mService: DreamOverlayService private class EnvironmentComponents( - val dreamsComplicationComponent: - com.android.systemui.dreams.complication.dagger.ComplicationComponent, + val dreamsComplicationComponent: DreamComplicationComponent, val dreamOverlayComponent: DreamOverlayComponent, val complicationComponent: ComplicationComponent, val ambientTouchComponent: AmbientTouchComponent, @@ -186,8 +185,7 @@ class DreamOverlayServiceTest(flags: FlagsParameterization?) : SysuiTestCase() { } private fun setupComponentFactories( - dreamComplicationComponentFactory: - com.android.systemui.dreams.complication.dagger.ComplicationComponent.Factory, + dreamComplicationComponentFactory: DreamComplicationComponent.Factory, dreamOverlayComponentFactory: DreamOverlayComponent.Factory, complicationComponentFactory: ComplicationComponent.Factory, ambientTouchComponentFactory: AmbientTouchComponent.Factory, @@ -208,8 +206,7 @@ class DreamOverlayServiceTest(flags: FlagsParameterization?) : SysuiTestCase() { whenever(complicationComponent.getVisibilityController()) .thenReturn(mComplicationVisibilityController) - val dreamComplicationComponent = - mock<com.android.systemui.dreams.complication.dagger.ComplicationComponent>() + val dreamComplicationComponent = mock<DreamComplicationComponent>() whenever(dreamComplicationComponent.getHideComplicationTouchHandler()) .thenReturn(mHideComplicationTouchHandler) whenever(dreamOverlayComponent.communalTouchHandler).thenReturn(mCommunalTouchHandler) diff --git a/packages/SystemUI/src/com/android/systemui/dreams/DreamOverlayService.java b/packages/SystemUI/src/com/android/systemui/dreams/DreamOverlayService.java index 43b7cedcd767..aee3a457e18a 100644 --- a/packages/SystemUI/src/com/android/systemui/dreams/DreamOverlayService.java +++ b/packages/SystemUI/src/com/android/systemui/dreams/DreamOverlayService.java @@ -65,6 +65,7 @@ import com.android.systemui.communal.shared.model.CommunalScenes; import com.android.systemui.communal.shared.model.CommunalTransitionKeys; import com.android.systemui.complication.dagger.ComplicationComponent; import com.android.systemui.dagger.qualifiers.Main; +import com.android.systemui.dreams.complication.dagger.DreamComplicationComponent; import com.android.systemui.dreams.dagger.DreamOverlayComponent; import com.android.systemui.keyguard.domain.interactor.KeyguardInteractor; import com.android.systemui.navigationbar.gestural.domain.GestureInteractor; @@ -141,8 +142,7 @@ public class DreamOverlayService extends android.service.dreams.DreamOverlayServ */ private boolean mBouncerShowing = false; - private final com.android.systemui.dreams.complication.dagger.ComplicationComponent.Factory - mDreamComplicationComponentFactory; + private final DreamComplicationComponent.Factory mDreamComplicationComponentFactory; private final ComplicationComponent.Factory mComplicationComponentFactory; private final DreamOverlayComponent.Factory mDreamOverlayComponentFactory; private final AmbientTouchComponent.Factory mAmbientTouchComponentFactory; @@ -376,8 +376,7 @@ public class DreamOverlayService extends android.service.dreams.DreamOverlayServ @Main DelayableExecutor executor, ViewCaptureAwareWindowManager viewCaptureAwareWindowManager, ComplicationComponent.Factory complicationComponentFactory, - com.android.systemui.dreams.complication.dagger.ComplicationComponent.Factory - dreamComplicationComponentFactory, + DreamComplicationComponent.Factory dreamComplicationComponentFactory, DreamOverlayComponent.Factory dreamOverlayComponentFactory, AmbientTouchComponent.Factory ambientTouchComponentFactory, DreamOverlayStateController stateController, @@ -479,9 +478,9 @@ public class DreamOverlayService extends android.service.dreams.DreamOverlayServ mLifecycleOwner, () -> mExecutor.execute(DreamOverlayService.this::requestExit), new ViewModelStore(), mTouchInsetManager); - final com.android.systemui.dreams.complication.dagger.ComplicationComponent - dreamComplicationComponent = mDreamComplicationComponentFactory.create( - complicationComponent.getVisibilityController(), mTouchInsetManager); + final DreamComplicationComponent dreamComplicationComponent = + mDreamComplicationComponentFactory.create( + complicationComponent.getVisibilityController(), mTouchInsetManager); final DreamOverlayComponent dreamOverlayComponent = mDreamOverlayComponentFactory.create( mLifecycleOwner, complicationComponent.getComplicationHostViewController(), diff --git a/packages/SystemUI/src/com/android/systemui/dreams/complication/HideComplicationTouchHandler.java b/packages/SystemUI/src/com/android/systemui/dreams/complication/HideComplicationTouchHandler.java index f8ae5c28d018..ea5fbc6fa0a1 100644 --- a/packages/SystemUI/src/com/android/systemui/dreams/complication/HideComplicationTouchHandler.java +++ b/packages/SystemUI/src/com/android/systemui/dreams/complication/HideComplicationTouchHandler.java @@ -17,8 +17,8 @@ package com.android.systemui.dreams.complication; import static com.android.systemui.Flags.removeDreamOverlayHideOnTouch; -import static com.android.systemui.dreams.complication.dagger.ComplicationModule.COMPLICATIONS_FADE_OUT_DELAY; -import static com.android.systemui.dreams.complication.dagger.ComplicationModule.COMPLICATIONS_RESTORE_TIMEOUT; +import static com.android.systemui.dreams.complication.dagger.DreamComplicationModule.COMPLICATIONS_FADE_OUT_DELAY; +import static com.android.systemui.dreams.complication.dagger.DreamComplicationModule.COMPLICATIONS_RESTORE_TIMEOUT; import android.util.Log; import android.view.MotionEvent; diff --git a/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/ComplicationComponent.kt b/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/DreamComplicationComponent.kt index 492c50255b18..17d3acd893e1 100644 --- a/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/ComplicationComponent.kt +++ b/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/DreamComplicationComponent.kt @@ -6,15 +6,15 @@ import com.android.systemui.touch.TouchInsetManager import dagger.BindsInstance import dagger.Subcomponent -@Subcomponent(modules = [ComplicationModule::class]) -interface ComplicationComponent { - /** Factory for generating [ComplicationComponent]. */ +@Subcomponent(modules = [DreamComplicationModule::class]) +interface DreamComplicationComponent { + /** Factory for generating [DreamComplicationComponent]. */ @Subcomponent.Factory interface Factory { fun create( @BindsInstance visibilityController: Complication.VisibilityController, - @BindsInstance touchInsetManager: TouchInsetManager - ): ComplicationComponent + @BindsInstance touchInsetManager: TouchInsetManager, + ): DreamComplicationComponent } fun getHideComplicationTouchHandler(): HideComplicationTouchHandler diff --git a/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/ComplicationModule.kt b/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/DreamComplicationModule.kt index 6fd6f4e3d4eb..59af22a6636f 100644 --- a/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/ComplicationModule.kt +++ b/packages/SystemUI/src/com/android/systemui/dreams/complication/dagger/DreamComplicationModule.kt @@ -1,14 +1,14 @@ package com.android.systemui.dreams.complication.dagger import android.content.res.Resources -import com.android.systemui.res.R import com.android.systemui.dagger.qualifiers.Main +import com.android.systemui.res.R import dagger.Module import dagger.Provides import javax.inject.Named @Module -object ComplicationModule { +object DreamComplicationModule { const val COMPLICATIONS_RESTORE_TIMEOUT = "complication_restore_timeout" const val COMPLICATIONS_FADE_OUT_DELAY = "complication_fade_out_delay" diff --git a/packages/SystemUI/src/com/android/systemui/dreams/dagger/DreamModule.java b/packages/SystemUI/src/com/android/systemui/dreams/dagger/DreamModule.java index 3171bbc6d6b0..216cb86f8865 100644 --- a/packages/SystemUI/src/com/android/systemui/dreams/dagger/DreamModule.java +++ b/packages/SystemUI/src/com/android/systemui/dreams/dagger/DreamModule.java @@ -32,7 +32,7 @@ import com.android.systemui.dagger.qualifiers.Main; import com.android.systemui.dreams.DreamOverlayNotificationCountProvider; import com.android.systemui.dreams.DreamOverlayService; import com.android.systemui.dreams.SystemDialogsCloser; -import com.android.systemui.dreams.complication.dagger.ComplicationComponent; +import com.android.systemui.dreams.complication.dagger.DreamComplicationComponent; import com.android.systemui.dreams.homecontrols.HomeControlsDreamService; import com.android.systemui.dreams.homecontrols.dagger.HomeControlsDataSourceModule; import com.android.systemui.dreams.homecontrols.dagger.HomeControlsRemoteServiceComponent; @@ -68,7 +68,7 @@ import javax.inject.Named; HomeControlsDataSourceModule.class, }, subcomponents = { - ComplicationComponent.class, + DreamComplicationComponent.class, DreamOverlayComponent.class, HomeControlsRemoteServiceComponent.class, }) |