summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Marzia Favaro <marziana@google.com> 2023-02-28 14:31:09 +0000
committer Marzia Favaro <marziana@google.com> 2023-03-03 11:50:26 +0000
commit6e312b9b711b9e36e0772cd55dd391455b130b7e (patch)
tree5b34182769b0266a656702bfaf315f9e079f33ff
parenta2abc8fb1266c3679be4082eaf4f5a584c5c276f (diff)
Prevent crash if detachWallpaperLocked is called multiple times
Test: no, minor change Bug: 242851438 Change-Id: I22b6e60ff4047fcb78624acbb1e30d84bca7df3d
-rw-r--r--services/core/java/com/android/server/wallpaper/WallpaperManagerService.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java b/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
index ac03808deba1..7a733592b30c 100644
--- a/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
+++ b/services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
@@ -945,7 +945,9 @@ public class WallpaperManagerService extends IWallpaperManager.Stub
mWindowManagerInternal.removeWindowToken(mToken, false/* removeWindows */,
mDisplayId);
try {
- connection.mService.detach(mToken);
+ if (connection.mService != null) {
+ connection.mService.detach(mToken);
+ }
} catch (RemoteException e) {
Slog.w(TAG, "connection.mService.destroy() threw a RemoteException");
}