summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Juan Sebastian Martinez <juansmartinez@google.com> 2024-09-17 15:16:19 -0700
committer Juan Sebastian Martinez <juansmartinez@google.com> 2024-09-17 15:16:19 -0700
commit6db075285f8fed1dfcc0bc868786a1cda817edd3 (patch)
treed3f4fde0ffc766759cccc51b1b8e57b09c5366c4
parent82fc0100cec3c850827f101e07f7b356a307552f (diff)
Removing TODO since bug is unfeasible.
The QSLongPressEffect is tailored to each tile's own state when it comes to touch handling and the long-press animation. Making the class a singleton could introduce more difficulties (complex touch handling, and state management) than benefits. Test: presubmit Flag: com.android.systemui.quick_settings_visual_haptics_longpress Bug: 332902869 Change-Id: I6c1e30b05aee27f530ec2c4f0ab3dd2a686feb4b
-rw-r--r--packages/SystemUI/src/com/android/systemui/haptics/qs/QSLongPressEffect.kt1
1 files changed, 0 insertions, 1 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/haptics/qs/QSLongPressEffect.kt b/packages/SystemUI/src/com/android/systemui/haptics/qs/QSLongPressEffect.kt
index 8966209d825e..e09e1987698d 100644
--- a/packages/SystemUI/src/com/android/systemui/haptics/qs/QSLongPressEffect.kt
+++ b/packages/SystemUI/src/com/android/systemui/haptics/qs/QSLongPressEffect.kt
@@ -45,7 +45,6 @@ import javax.inject.Inject
* @property[vibratorHelper] The [VibratorHelper] to deliver haptic effects.
* @property[effectDuration] The duration of the effect in ms.
*/
-// TODO(b/332902869): In addition from being injectable, we can consider making it a singleton
class QSLongPressEffect
@Inject
constructor(