diff options
author | 2020-08-12 09:44:55 -0400 | |
---|---|---|
committer | 2020-08-13 19:09:48 +0000 | |
commit | 6d9f5938638a986a6e65d2b6d17f0e97be8f79e8 (patch) | |
tree | ff9e7a54237cbd727958f3150f22b756f479af8a | |
parent | f2c039bb19845ca45b7cae0dffad7b0cbb1b6bec (diff) |
Launch intents from notifications from main thread
Test: manual (turn on new pipeline rendering, tap on notif)
Change-Id: Iefcb1420d8363bdbc5eefe5064a54899e7045d69
2 files changed, 2 insertions, 13 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java index 4de648402464..b9f94b37d7d3 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarter.java @@ -49,7 +49,6 @@ import com.android.systemui.ActivityIntentHelper; import com.android.systemui.EventLogTags; import com.android.systemui.assist.AssistManager; import com.android.systemui.bubbles.BubbleController; -import com.android.systemui.dagger.qualifiers.Background; import com.android.systemui.dagger.qualifiers.Main; import com.android.systemui.dagger.qualifiers.UiBackground; import com.android.systemui.plugins.ActivityStarter; @@ -93,7 +92,6 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit private final CommandQueue mCommandQueue; private final Handler mMainThreadHandler; - private final Handler mBackgroundHandler; private final Executor mUiBgExecutor; private final NotificationEntryManager mEntryManager; @@ -134,7 +132,6 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit Context context, CommandQueue commandQueue, Handler mainThreadHandler, - Handler backgroundHandler, Executor uiBgExecutor, NotificationEntryManager entryManager, NotifPipeline notifPipeline, @@ -170,7 +167,6 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit mContext = context; mCommandQueue = commandQueue; mMainThreadHandler = mainThreadHandler; - mBackgroundHandler = backgroundHandler; mUiBgExecutor = uiBgExecutor; mEntryManager = entryManager; mNotifPipeline = notifPipeline; @@ -307,7 +303,7 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit mStatusBarKeyguardViewManager.addAfterKeyguardGoneRunnable(runnable); mShadeController.collapsePanel(); } else { - mBackgroundHandler.postAtFrontOfQueue(runnable); + runnable.run(); } return !mNotificationPanel.isFullyCollapsed(); } @@ -605,7 +601,7 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit private final Context mContext; private final CommandQueue mCommandQueue; private final Handler mMainThreadHandler; - private final Handler mBackgroundHandler; + private final Executor mUiBgExecutor; private final NotificationEntryManager mEntryManager; private final NotifPipeline mNotifPipeline; @@ -644,7 +640,6 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit Context context, CommandQueue commandQueue, @Main Handler mainThreadHandler, - @Background Handler backgroundHandler, @UiBackground Executor uiBgExecutor, NotificationEntryManager entryManager, NotifPipeline notifPipeline, @@ -676,7 +671,6 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit mContext = context; mCommandQueue = commandQueue; mMainThreadHandler = mainThreadHandler; - mBackgroundHandler = backgroundHandler; mUiBgExecutor = uiBgExecutor; mEntryManager = entryManager; mNotifPipeline = notifPipeline; @@ -734,7 +728,6 @@ public class StatusBarNotificationActivityStarter implements NotificationActivit mContext, mCommandQueue, mMainThreadHandler, - mBackgroundHandler, mUiBgExecutor, mEntryManager, mNotifPipeline, diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarterTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarterTest.java index 33067343ba40..a71b10cf9264 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarterTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarNotificationActivityStarterTest.java @@ -184,7 +184,6 @@ public class StatusBarNotificationActivityStarterTest extends SysuiTestCase { getContext(), mock(CommandQueue.class), mHandler, - mHandler, mUiBgExecutor, mEntryManager, mNotifPipeline, @@ -234,9 +233,6 @@ public class StatusBarNotificationActivityStarterTest extends SysuiTestCase { // set up Handler to synchronously invoke the Runnable arg doAnswer(answerVoid(Runnable::run)) .when(mHandler).post(any(Runnable.class)); - - doAnswer(answerVoid(Runnable::run)) - .when(mHandler).postAtFrontOfQueue(any(Runnable.class)); } @Test |