diff options
| author | 2017-10-27 18:41:59 +0000 | |
|---|---|---|
| committer | 2017-10-27 18:41:59 +0000 | |
| commit | 6ac8f42d9ea1388f20400f7609b62d858ef6b7a9 (patch) | |
| tree | 7287c64924c4029f133a7f1d86b6556f0e897c6d | |
| parent | bf74a93eb2991e738efca80a7a1ce8d997f4e9f6 (diff) | |
| parent | be2d96a724a5ecbf0d5b9be9e47d89034971f4a6 (diff) | |
Merge "Fix: AccountManagerService crashed by accessing closed db"
| -rw-r--r-- | services/core/java/com/android/server/accounts/AccountManagerService.java | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/services/core/java/com/android/server/accounts/AccountManagerService.java b/services/core/java/com/android/server/accounts/AccountManagerService.java index f82eb1f3e991..86ce12eee32b 100644 --- a/services/core/java/com/android/server/accounts/AccountManagerService.java +++ b/services/core/java/com/android/server/accounts/AccountManagerService.java @@ -5068,8 +5068,16 @@ public class AccountManagerService logStatement.bindLong(4, callingUid); logStatement.bindString(5, tableName); logStatement.bindLong(6, userDebugDbInsertionPoint); - logStatement.execute(); - logStatement.clearBindings(); + try { + logStatement.execute(); + } catch (IllegalStateException e) { + // Guard against crash, DB can already be closed + // since this statement is executed on a handler thread + Slog.w(TAG, "Failed to insert a log record. accountId=" + accountId + + " action=" + action + " tableName=" + tableName + " Error: " + e); + } finally { + logStatement.clearBindings(); + } } } |