summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Fan Zhang <zhfan@google.com> 2018-11-09 14:54:06 -0800
committer Fan Zhang <zhfan@google.com> 2018-11-11 18:55:58 -0800
commit6a607e7cc8f11f5e2e4e154a3e6c142333066f64 (patch)
treeb3c9b570fc42eea2b083620d33a9bcd7dc07e6b1
parented50a5ac4b8438787d732b6cfcd3d2888494a91d (diff)
Delete actionWithSource. Caller can use action directly.
Bug: 117860032 Test: robotest Change-Id: Ie9d8a8605e4c02568394e50d59a263cd72a6fbf6
-rw-r--r--packages/SettingsLib/src/com/android/settingslib/core/instrumentation/EventLogWriter.java12
-rw-r--r--packages/SettingsLib/src/com/android/settingslib/core/instrumentation/LogWriter.java5
-rw-r--r--packages/SettingsLib/src/com/android/settingslib/core/instrumentation/MetricsFeatureProvider.java6
3 files changed, 0 insertions, 23 deletions
diff --git a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/EventLogWriter.java b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/EventLogWriter.java
index d5afee94c3b9..630e6a6ab6d0 100644
--- a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/EventLogWriter.java
+++ b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/EventLogWriter.java
@@ -29,8 +29,6 @@ import com.android.internal.logging.nano.MetricsProto;
*/
public class EventLogWriter implements LogWriter {
- private final MetricsLogger mMetricsLogger = new MetricsLogger();
-
@Override
public void visible(Context context, int source, int category) {
final LogMaker logMaker = new LogMaker(category)
@@ -50,16 +48,6 @@ public class EventLogWriter implements LogWriter {
}
@Override
- public void actionWithSource(Context context, int source, int category) {
- final LogMaker logMaker = new LogMaker(category)
- .setType(MetricsProto.MetricsEvent.TYPE_ACTION);
- if (source != MetricsProto.MetricsEvent.VIEW_UNKNOWN) {
- logMaker.addTaggedData(MetricsProto.MetricsEvent.FIELD_CONTEXT, source);
- }
- MetricsLogger.action(logMaker);
- }
-
- @Override
public void action(Context context, int category, int value) {
MetricsLogger.action(context, category, value);
}
diff --git a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/LogWriter.java b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/LogWriter.java
index 16ae7103e374..466250373f5f 100644
--- a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/LogWriter.java
+++ b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/LogWriter.java
@@ -41,11 +41,6 @@ public interface LogWriter {
/**
* Logs an user action.
*/
- void actionWithSource(Context context, int source, int category);
-
- /**
- * Logs an user action.
- */
void action(Context context, int category, int value);
/**
diff --git a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/MetricsFeatureProvider.java b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/MetricsFeatureProvider.java
index 50834bc85ec9..df691381ebc0 100644
--- a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/MetricsFeatureProvider.java
+++ b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/MetricsFeatureProvider.java
@@ -53,12 +53,6 @@ public class MetricsFeatureProvider {
}
}
- public void actionWithSource(Context context, int source, int category) {
- for (LogWriter writer : mLoggerWriters) {
- writer.actionWithSource(context, source, category);
- }
- }
-
public void action(Context context, int category, Pair<Integer, Object>... taggedData) {
for (LogWriter writer : mLoggerWriters) {
writer.action(context, category, taggedData);